From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx195.postini.com [74.125.245.195]) by kanga.kvack.org (Postfix) with SMTP id 6D2EE6B0002 for ; Tue, 2 Apr 2013 07:20:52 -0400 (EDT) Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 2 Apr 2013 16:47:59 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id EC6A91258023 for ; Tue, 2 Apr 2013 16:52:03 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r32BKfOa262634 for ; Tue, 2 Apr 2013 16:50:42 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r32BKhA3009806 for ; Tue, 2 Apr 2013 22:20:43 +1100 Date: Tue, 2 Apr 2013 19:20:41 +0800 From: Wanpeng Li Subject: Re: [PATCH] mm/vmscan: fix error return in kswapd_run() Message-ID: <20130402112041.GA17704@hacker.(null)> Reply-To: Wanpeng Li References: <515ABC79.5060900@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515ABC79.5060900@huawei.com> Sender: owner-linux-mm@kvack.org List-ID: To: Xishi Qiu Cc: Andrew Morton , Mel Gorman , hughd@google.com, riel@redhat.com, khlebnikov@openvz.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hanjun Guo , Zhangdianfang On Tue, Apr 02, 2013 at 07:09:45PM +0800, Xishi Qiu wrote: >Fix the error return value in kswapd_run(). The bug was >introduced by commit d5dc0ad928fb9e972001e552597fd0b794863f34 >"mm/vmscan: fix error number for failed kthread". > Reviewed-by: Wanpeng Li >Signed-off-by: Xishi Qiu >--- > mm/vmscan.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/mm/vmscan.c b/mm/vmscan.c >index 88c5fed..950636e 100644 >--- a/mm/vmscan.c >+++ b/mm/vmscan.c >@@ -3188,9 +3188,9 @@ int kswapd_run(int nid) > if (IS_ERR(pgdat->kswapd)) { > /* failure at boot is fatal */ > BUG_ON(system_state == SYSTEM_BOOTING); >- pgdat->kswapd = NULL; > pr_err("Failed to start kswapd on node %d\n", nid); > ret = PTR_ERR(pgdat->kswapd); >+ pgdat->kswapd = NULL; > } > return ret; > } >-- >1.7.6.1 > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org