* [PATCH] mm/vmscan: fix error return in kswapd_run()
@ 2013-04-02 11:09 Xishi Qiu
2013-04-02 11:20 ` Wanpeng Li
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Xishi Qiu @ 2013-04-02 11:09 UTC (permalink / raw)
To: Andrew Morton, Mel Gorman, hughd, riel, khlebnikov
Cc: linux-mm, linux-kernel, Xishi Qiu, Hanjun Guo, Zhangdianfang
Fix the error return value in kswapd_run(). The bug was
introduced by commit d5dc0ad928fb9e972001e552597fd0b794863f34
"mm/vmscan: fix error number for failed kthread".
Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
---
mm/vmscan.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 88c5fed..950636e 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -3188,9 +3188,9 @@ int kswapd_run(int nid)
if (IS_ERR(pgdat->kswapd)) {
/* failure at boot is fatal */
BUG_ON(system_state == SYSTEM_BOOTING);
- pgdat->kswapd = NULL;
pr_err("Failed to start kswapd on node %d\n", nid);
ret = PTR_ERR(pgdat->kswapd);
+ pgdat->kswapd = NULL;
}
return ret;
}
--
1.7.6.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mm/vmscan: fix error return in kswapd_run()
2013-04-02 11:09 [PATCH] mm/vmscan: fix error return in kswapd_run() Xishi Qiu
@ 2013-04-02 11:20 ` Wanpeng Li
2013-04-02 11:20 ` Wanpeng Li
2013-04-02 14:57 ` Rik van Riel
2 siblings, 0 replies; 4+ messages in thread
From: Wanpeng Li @ 2013-04-02 11:20 UTC (permalink / raw)
Cc: Andrew Morton, Mel Gorman, hughd, riel, khlebnikov, linux-mm,
linux-kernel, Xishi Qiu, Hanjun Guo, Zhangdianfang
On Tue, Apr 02, 2013 at 07:09:45PM +0800, Xishi Qiu wrote:
>Fix the error return value in kswapd_run(). The bug was
>introduced by commit d5dc0ad928fb9e972001e552597fd0b794863f34
>"mm/vmscan: fix error number for failed kthread".
>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
>---
> mm/vmscan.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/mm/vmscan.c b/mm/vmscan.c
>index 88c5fed..950636e 100644
>--- a/mm/vmscan.c
>+++ b/mm/vmscan.c
>@@ -3188,9 +3188,9 @@ int kswapd_run(int nid)
> if (IS_ERR(pgdat->kswapd)) {
> /* failure at boot is fatal */
> BUG_ON(system_state == SYSTEM_BOOTING);
>- pgdat->kswapd = NULL;
> pr_err("Failed to start kswapd on node %d\n", nid);
> ret = PTR_ERR(pgdat->kswapd);
>+ pgdat->kswapd = NULL;
> }
> return ret;
> }
>--
>1.7.6.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm/vmscan: fix error return in kswapd_run()
2013-04-02 11:09 [PATCH] mm/vmscan: fix error return in kswapd_run() Xishi Qiu
2013-04-02 11:20 ` Wanpeng Li
@ 2013-04-02 11:20 ` Wanpeng Li
2013-04-02 14:57 ` Rik van Riel
2 siblings, 0 replies; 4+ messages in thread
From: Wanpeng Li @ 2013-04-02 11:20 UTC (permalink / raw)
To: Xishi Qiu
Cc: Andrew Morton, Mel Gorman, hughd, riel, khlebnikov, linux-mm,
linux-kernel, Hanjun Guo, Zhangdianfang
On Tue, Apr 02, 2013 at 07:09:45PM +0800, Xishi Qiu wrote:
>Fix the error return value in kswapd_run(). The bug was
>introduced by commit d5dc0ad928fb9e972001e552597fd0b794863f34
>"mm/vmscan: fix error number for failed kthread".
>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
>---
> mm/vmscan.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/mm/vmscan.c b/mm/vmscan.c
>index 88c5fed..950636e 100644
>--- a/mm/vmscan.c
>+++ b/mm/vmscan.c
>@@ -3188,9 +3188,9 @@ int kswapd_run(int nid)
> if (IS_ERR(pgdat->kswapd)) {
> /* failure at boot is fatal */
> BUG_ON(system_state == SYSTEM_BOOTING);
>- pgdat->kswapd = NULL;
> pr_err("Failed to start kswapd on node %d\n", nid);
> ret = PTR_ERR(pgdat->kswapd);
>+ pgdat->kswapd = NULL;
> }
> return ret;
> }
>--
>1.7.6.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm/vmscan: fix error return in kswapd_run()
2013-04-02 11:09 [PATCH] mm/vmscan: fix error return in kswapd_run() Xishi Qiu
2013-04-02 11:20 ` Wanpeng Li
2013-04-02 11:20 ` Wanpeng Li
@ 2013-04-02 14:57 ` Rik van Riel
2 siblings, 0 replies; 4+ messages in thread
From: Rik van Riel @ 2013-04-02 14:57 UTC (permalink / raw)
To: Xishi Qiu
Cc: Andrew Morton, Mel Gorman, hughd, khlebnikov, linux-mm,
linux-kernel, Hanjun Guo, Zhangdianfang
On 04/02/2013 07:09 AM, Xishi Qiu wrote:
> Fix the error return value in kswapd_run(). The bug was
> introduced by commit d5dc0ad928fb9e972001e552597fd0b794863f34
> "mm/vmscan: fix error number for failed kthread".
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-02 14:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-02 11:09 [PATCH] mm/vmscan: fix error return in kswapd_run() Xishi Qiu
2013-04-02 11:20 ` Wanpeng Li
2013-04-02 11:20 ` Wanpeng Li
2013-04-02 14:57 ` Rik van Riel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).