From: Oleg Nesterov <oleg@redhat.com>
To: Frantisek Hrbata <fhrbata@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, kamaleshb@in.ibm.com, hechjie@cn.ibm.com
Subject: Re: [PATCH] x86: add phys addr validity check for /dev/mem mmap
Date: Tue, 2 Apr 2013 20:02:19 +0200 [thread overview]
Message-ID: <20130402180219.GA26833@redhat.com> (raw)
In-Reply-To: <1364905733-23937-1-git-send-email-fhrbata@redhat.com>
On 04/02, Frantisek Hrbata wrote:
>
> Meaning there is a possibility to use mmap
> on /dev/mem and cause system panic. It's probably not that serious, because
> access to /dev/mem is limited and the system has to have panic_on_oops set, but
> still I think we should check this and return error.
Personally I agree. Even if panic_on_oops == F, do_page_fault(PF_RSVD) leading
to pgtable_bad() doesn't look good.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-02 18:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 12:28 [PATCH] x86: add phys addr validity check for /dev/mem mmap Frantisek Hrbata
2013-04-02 18:02 ` Oleg Nesterov [this message]
2013-04-02 18:48 ` H. Peter Anvin
2013-04-02 19:10 ` Frantisek Hrbata
2013-04-02 20:29 ` H. Peter Anvin
2013-04-02 20:52 ` Frantisek Hrbata
2013-04-24 11:36 ` Frantisek Hrbata
2013-04-04 1:11 ` Simon Jeons
2013-04-04 1:13 ` H. Peter Anvin
2013-04-04 1:17 ` Simon Jeons
2013-04-04 1:32 ` H. Peter Anvin
2013-04-04 1:53 ` Simon Jeons
2013-04-04 2:14 ` H. Peter Anvin
2013-04-04 2:17 ` Simon Jeons
2013-04-04 5:20 ` Simon Jeons
2013-04-11 2:40 ` Simon Jeons
2013-04-11 2:48 ` H. Peter Anvin
2013-04-11 2:58 ` Simon Jeons
2013-04-03 2:46 ` Cheng Jie He
2013-04-26 5:21 ` Will Huck
2013-04-26 15:35 ` Frantisek Hrbata
2013-04-27 7:00 ` Will Huck
2013-04-27 19:13 ` Frantisek Hrbata
2013-04-28 3:17 ` Will Huck
2013-04-28 4:00 ` H. Peter Anvin
2013-04-28 8:03 ` Will Huck
2013-05-01 18:19 ` Dave Hansen
2013-05-01 19:04 ` Frantisek Hrbata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402180219.GA26833@redhat.com \
--to=oleg@redhat.com \
--cc=fhrbata@redhat.com \
--cc=hechjie@cn.ibm.com \
--cc=hpa@zytor.com \
--cc=kamaleshb@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).