linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>, Mel Gorman <mgorman@suse.de>,
	Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Hugh Dickins <hughd@google.com>,
	Sangseok Lee <sangseok.lee@lge.com>
Subject: Re: [RFC 4/4] mm: Enhance per process reclaim
Date: Wed, 3 Apr 2013 09:23:09 +0900	[thread overview]
Message-ID: <20130403002309.GD16026@blaptop> (raw)
In-Reply-To: <CAHO5Pa1LiBw8P5On0X3__49P8zeY4xwEU63KBoKWEpLTOHjeTw@mail.gmail.com>

Hey Michael,

On Tue, Apr 02, 2013 at 03:25:25PM +0200, Michael Kerrisk wrote:
> Minchan,
> 
> On Mon, Mar 25, 2013 at 7:21 AM, Minchan Kim <minchan@kernel.org> wrote:
> >
> > Some pages could be shared by several processes. (ex, libc)
> > In case of that, it's too bad to reclaim them from the beginnig.
> >
> > This patch causes VM to keep them on memory until last task
> > try to reclaim them so shared pages will be reclaimed only if
> > all of task has gone swapping out.
> >
> > This feature doesn't handle non-linear mapping on ramfs because
> > it's very time-consuming and doesn't make sure of reclaiming and
> > not common.
> 
> Against what tree does this patch apply? I've tries various trees,
> including MMOTM of 26 March, and encounter this error:
> 
>   CC      mm/ksm.o
> mm/ksm.c: In function a??try_to_unmap_ksma??:
> mm/ksm.c:1970:32: error: a??vmaa?? undeclared (first use in this function)
> mm/ksm.c:1970:32: note: each undeclared identifier is reported only
> once for each function it appears in
> make[1]: *** [mm/ksm.o] Error 1
> make: *** [mm] Error 2

I did it based on mmotm-2013-03-22-15-21 and you found build problem.
Could you apply below patch? I will fix up below in next spin.
Thanks for the testing!

  reply	other threads:[~2013-04-03  0:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-25  6:21 [RFC 1/4] mm: Per process reclaim Minchan Kim
2013-03-25  6:21 ` [RFC 2/4] mm: make shrink_page_list with pages from multiple zones Minchan Kim
2013-03-25  6:21 ` [RFC 3/4] mm: Remove shrink_page Minchan Kim
2013-03-25  6:21 ` [RFC 4/4] mm: Enhance per process reclaim Minchan Kim
2013-04-02 13:25   ` Michael Kerrisk
2013-04-03  0:23     ` Minchan Kim [this message]
2013-04-03  6:16       ` Michael Kerrisk (man-pages)
2013-04-03  6:47         ` Michael Kerrisk (man-pages)
2013-04-03  9:17 ` [RFC 1/4] mm: Per " Michael Kerrisk
2013-04-03 23:31   ` Minchan Kim
2013-04-03 10:10 ` Michael Kerrisk
2013-04-03 10:12   ` Michael Kerrisk
2013-04-03 23:46   ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130403002309.GD16026@blaptop \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mtk.manpages@gmail.com \
    --cc=riel@redhat.com \
    --cc=sangseok.lee@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).