From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Minchan Kim <minchan@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Bob Liu <bob.liu@oracle.com>, Ric Mason <ric.masonn@gmail.com>
Subject: Re: [PATCH part2 v6 0/3] staging: zcache: Support zero-filled pages more efficiently
Date: Mon, 8 Apr 2013 08:27:04 +0800 [thread overview]
Message-ID: <20130408002704.GA2856@hacker.(null)> (raw)
In-Reply-To: <dc2642fc-f662-41cd-a236-fccf4c252dfa@default>
On Sun, Apr 07, 2013 at 10:59:18AM -0700, Dan Magenheimer wrote:
>> From: Dan Magenheimer
>> Subject: RE: [PATCH part2 v6 0/3] staging: zcache: Support zero-filled pages more efficiently
>>
>> > From: Wanpeng Li [mailto:liwanp@linux.vnet.ibm.com]
>> > Subject: Re: [PATCH part2 v6 0/3] staging: zcache: Support zero-filled pages more efficiently
>> >
>> > Hi Dan,
>> >
>> > Some issues against Ramster:
>> >
>>
>> Sure! I am concerned about Konrad's patches adding debug.c as they
>> add many global variables. They are only required when ZCACHE_DEBUG
>> is enabled so they may be ok. If not, adding ramster variables
>> to debug.c may make the problem worse.
>
>Oops, I just noticed/remembered that ramster uses BOTH debugfs and sysfs.
>The sysfs variables are all currently required, i.e. for configuration
>so should not be tied to debugfs or a DEBUG config option. However,
>if there is a more acceptable way to implement the function of
>those sysfs variables, that would be fine.
So if we need move debugfs counters to a single debug.c in
zcache/ramster/ and introduce RAMSTER_DEBUG? The work similiar
as Konrad done against zcache. ;-)
Regards,
Wanpeng Li
>
>Thanks,
>Dan
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-08 0:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 10:16 [PATCH part2 v6 0/3] staging: zcache: Support zero-filled pages more efficiently Wanpeng Li
2013-04-03 10:16 ` [PATCH v6 1/3] staging: zcache: fix static variables defined in debug.h but used in mutiple C files Wanpeng Li
2013-04-03 20:13 ` Konrad Rzeszutek Wilk
2013-04-03 10:16 ` [PATCH v6 2/3] staging: zcache: introduce zero-filled page stat count Wanpeng Li
2013-04-03 20:12 ` Konrad Rzeszutek Wilk
2013-04-03 10:16 ` [PATCH v2 3/3] staging: zcache: clean TODO list Wanpeng Li
2013-04-07 9:03 ` [PATCH part2 v6 0/3] staging: zcache: Support zero-filled pages more efficiently Wanpeng Li
2013-04-07 9:03 ` Wanpeng Li
2013-04-07 17:51 ` Dan Magenheimer
2013-04-07 17:59 ` Dan Magenheimer
2013-04-08 0:27 ` Wanpeng Li [this message]
2013-04-08 0:27 ` Wanpeng Li
2013-04-08 12:09 ` Wanpeng Li
2013-04-08 12:09 ` Wanpeng Li
2013-04-10 0:38 ` Wanpeng Li
2013-04-10 0:38 ` Wanpeng Li
[not found] ` <5161367e.c60c320a.5936.ffff86a9SMTPIN_ADDED_BROKEN@mx.google.com>
2013-04-07 9:12 ` Ric Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130408002704.GA2856@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bob.liu@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ric.masonn@gmail.com \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).