linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Print the correct method to disable automatic numa migration
Date: Thu, 11 Apr 2013 18:25:08 +0100	[thread overview]
Message-ID: <20130411172508.GC11656@suse.de> (raw)
In-Reply-To: <20130411155304.GK22166@tassilo.jf.intel.com>

On Thu, Apr 11, 2013 at 08:53:04AM -0700, Andi Kleen wrote:
> > > > David has also already pointed out the problems with NO_NUMA vs -NUMA and
> > > > the fact that the option only exists if CONFIG_SCHED_DEBUG which I agree
> > > > is unfortunate. Ends up with this sort of mess
> > > 
> > > We just need the sysctl. Are you adding one or should I send
> > > another patch with it?
> > > 
> > 
> > I hadn't planned on it in the short term at least. Originally there was
> 
> I'll send a patch.
> 

Ok.

> But are you taking care of the documentation of all the existing knobs?
> 

Which knobs? The sched_features knobs? No, I was not planning on
documenting them. Some of them are already partially documented in
kernel/sched/features.h but the consequences of tuning them is heavily
workload dependant. While this is unsatisfactory, the interface is only
intended for debugging. For NUMA balancing, the tuning knob is a kernel
parameter and it is already documented in Documentation/kernel-parameters.txt

> I think if you had done that earlier you would have noticed
> that the current situation is not very satisfying.
> 
> Writing documentation is one of the best ways we have
> to sanitize user interfaces.
> 
> > revisited NUMA balancing a long time ago but too many bugs have been
> > getting in the way.
> 
> That will likely make everything even worse.
> 

With one exception, the bugs I've been working on are not related to
automatic NUMA balancing.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-04-11 17:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10 19:35 [PATCH] mm: Print the correct method to disable automatic numa migration Andi Kleen
2013-04-10 21:15 ` David Rientjes
2013-04-10 21:26   ` Andi Kleen
2013-04-10 21:29     ` David Rientjes
2013-04-11 12:48 ` Mel Gorman
2013-04-11 14:04   ` Andi Kleen
2013-04-11 14:19     ` Mel Gorman
2013-04-11 15:53       ` Andi Kleen
2013-04-11 17:25         ` Mel Gorman [this message]
2013-04-11 17:39           ` Andi Kleen
2013-04-11 17:48             ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130411172508.GC11656@suse.de \
    --to=mgorman@suse.de \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).