From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx125.postini.com [74.125.245.125]) by kanga.kvack.org (Postfix) with SMTP id CDC866B0027 for ; Thu, 11 Apr 2013 19:27:51 -0400 (EDT) Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 12 Apr 2013 04:52:16 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 9F8453940023 for ; Fri, 12 Apr 2013 04:57:43 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3BNRbYj10944820 for ; Fri, 12 Apr 2013 04:57:37 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3BNRgIO014212 for ; Fri, 12 Apr 2013 09:27:43 +1000 Date: Fri, 12 Apr 2013 07:27:41 +0800 From: Wanpeng Li Subject: Re: [PATCH 05/10] staging: ramster: Move debugfs code out of ramster.c file Message-ID: <20130411232741.GA30716@hacker.(null)> Reply-To: Wanpeng Li References: <1365553560-32258-1-git-send-email-liwanp@linux.vnet.ibm.com> <1365553560-32258-6-git-send-email-liwanp@linux.vnet.ibm.com> <20130411200428.GA31680@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130411200428.GA31680@kroah.com> Sender: owner-linux-mm@kvack.org List-ID: To: Greg Kroah-Hartman Cc: Dan Magenheimer , Seth Jennings , Konrad Rzeszutek Wilk , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Bob Liu On Thu, Apr 11, 2013 at 01:04:28PM -0700, Greg Kroah-Hartman wrote: >On Wed, Apr 10, 2013 at 08:25:55AM +0800, Wanpeng Li wrote: >> Note that at this point there is no CONFIG_RAMSTER_DEBUG >> option in the Kconfig. So in effect all of the counters >> are nop until that option gets re-introduced in: >> zcache/ramster/debug: Add RAMSTE_DEBUG Kconfig entry > >This patch breaks the build badly: > >drivers/staging/zcache/ramster/ramster.c: In function a??ramster_localifya??: >drivers/staging/zcache/ramster/ramster.c:159:4: error: a??ramster_remote_eph_pages_unsucc_geta?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c:159:4: note: each undeclared identifier is reported only once for each function it appears in >drivers/staging/zcache/ramster/ramster.c:161:4: error: a??ramster_remote_pers_pages_unsucc_geta?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c:212:3: error: a??ramster_remote_eph_pages_succ_geta?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c:214:3: error: a??ramster_remote_pers_pages_succ_geta?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c: In function a??ramster_pampd_repatriate_preloada??: >drivers/staging/zcache/ramster/ramster.c:299:3: error: a??ramster_pers_pages_remote_nomema?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c: In function a??ramster_remote_flush_pagea??: >drivers/staging/zcache/ramster/ramster.c:437:3: error: a??ramster_remote_pages_flusheda?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c:439:3: error: a??ramster_remote_page_flushes_faileda?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c: In function a??ramster_remote_flush_objecta??: >drivers/staging/zcache/ramster/ramster.c:454:3: error: a??ramster_remote_objects_flusheda?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c:456:3: error: a??ramster_remote_object_flushes_faileda?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c: In function a??ramster_remotify_pageframea??: >drivers/staging/zcache/ramster/ramster.c:507:5: error: a??ramster_eph_pages_remote_faileda?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c:509:5: error: a??ramster_pers_pages_remote_faileda?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c:516:4: error: a??ramster_eph_pages_remoteda?? undeclared (first use in this function) >drivers/staging/zcache/ramster/ramster.c:518:4: error: a??ramster_pers_pages_remoteda?? undeclared (first use in this function) >make[3]: *** [drivers/staging/zcache/ramster/ramster.o] Error 1 > >Please always test your patches. > >I've applied patch 1, 3, and 4 in this series. Please fix this up if you want >me to apply anything else. Sorry for the bisect issue in my patchset, I will fix it and repost ASAP. Thanks for your patient. Regards, Wanpeng Li > >greg k-h > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org