From: Mel Gorman <mgorman@suse.de>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] swap: redirty page if page write fails on swap file
Date: Wed, 17 Apr 2013 16:08:37 +0100 [thread overview]
Message-ID: <20130417150837.GB1852@suse.de> (raw)
In-Reply-To: <516E918B.3050309@redhat.com>
On Wed, Apr 17, 2013 at 02:11:55PM +0200, Jerome Marchand wrote:
>
> Since commit 62c230b, swap_writepage() calls direct_IO on swap files.
> However, in that case page isn't redirtied if I/O fails, and is therefore
> handled afterwards as if it has been successfully written to the swap
> file, leading to memory corruption when the page is eventually swapped
> back in.
> This patch sets the page dirty when direct_IO() fails. It fixes a memory
> corruption that happened while using swap-over-NFS.
>
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
Acked-by: Mel Gorman <mgorman@suse.de>
Thanks Jerome. I've added Andrew to the cc and this should also be
considered a candidate for 3.8-stable.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-17 15:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 12:11 [PATCH] swap: redirty page if page write fails on swap file Jerome Marchand
2013-04-17 15:07 ` Johannes Weiner
2013-04-17 15:08 ` Mel Gorman [this message]
2013-04-18 0:13 ` Simon Jeons
2013-05-01 7:39 ` Simon Jeons
2013-05-03 9:12 ` Jerome Marchand
2013-04-22 20:37 ` Andrew Morton
2013-04-24 9:57 ` Jerome Marchand
2013-05-01 7:38 ` Will Huck
2013-04-24 18:57 ` [PATCH] mm: swap: Mark swap pages writeback before queueing for direct IO Mel Gorman
2013-04-24 19:23 ` Andrew Morton
2013-04-25 8:53 ` Mel Gorman
2013-05-01 6:58 ` Ric Mason
2013-05-01 8:20 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130417150837.GB1852@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).