[RESEND PATCH 3.8-stable] mm/vmscan: fix error return in kswapd_run()

[RESEND PATCH 3.8-stable] mm/vmscan: fix error return in kswapd_run()

[Jonghwan Choi]

From: Gavin Shan <shangw@linux.vnet.ibm.com>

This patch looks like it should be in the 3.8-stable tree, should we apply
it?

------------------

From: "Gavin Shan <shangw@linux.vnet.ibm.com>"

commit d5dc0ad928fb9e972001e552597fd0b794863f34 upstream

Fix the error return value in kswapd_run().  The bug was introduced by
commit d5dc0ad928fb ("mm/vmscan: fix error number for failed kthread").

Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
Reported-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
 mm/vmscan.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 196709f..8226b41 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -3158,9 +3158,9 @@ int kswapd_run(int nid)
 	if (IS_ERR(pgdat->kswapd)) {
 		/* failure at boot is fatal */
 		BUG_ON(system_state == SYSTEM_BOOTING);
-		pgdat->kswapd = NULL;
 		pr_err("Failed to start kswapd on node %d\n", nid);
 		ret = PTR_ERR(pgdat->kswapd);
+		pgdat->kswapd = NULL;
 	}
 	return ret;
 }
-- 
1.7.10.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [RESEND PATCH 3.8-stable] mm/vmscan: fix error return in kswapd_run()

[Gavin Shan]

On Fri, Apr 19, 2013 at 11:52:10PM +0900, Jonghwan Choi wrote:
>From: Gavin Shan <shangw@linux.vnet.ibm.com>
>
>This patch looks like it should be in the 3.8-stable tree, should we apply
>it?
>

Yes, I think so. If possible, please apply to 3.8-stable.

Thanks,
Gavin

>------------------
>
>From: "Gavin Shan <shangw@linux.vnet.ibm.com>"
>
>commit d5dc0ad928fb9e972001e552597fd0b794863f34 upstream
>
>Fix the error return value in kswapd_run().  The bug was introduced by
>commit d5dc0ad928fb ("mm/vmscan: fix error number for failed kthread").
>
>Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
>Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>Reviewed-by: Rik van Riel <riel@redhat.com>
>Reported-by: Wu Fengguang <fengguang.wu@intel.com>
>Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
>---
> mm/vmscan.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/vmscan.c b/mm/vmscan.c
>index 196709f..8226b41 100644
>--- a/mm/vmscan.c
>+++ b/mm/vmscan.c
>@@ -3158,9 +3158,9 @@ int kswapd_run(int nid)
> 	if (IS_ERR(pgdat->kswapd)) {
> 		/* failure at boot is fatal */
> 		BUG_ON(system_state == SYSTEM_BOOTING);
>-		pgdat->kswapd = NULL;
> 		pr_err("Failed to start kswapd on node %d\n", nid);
> 		ret = PTR_ERR(pgdat->kswapd);
>+		pgdat->kswapd = NULL;
> 	}
> 	return ret;
> }
>-- 
>1.7.10.4
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [RESEND PATCH 3.8-stable] mm/vmscan: fix error return in kswapd_run()

[Gavin Shan]

On Fri, Apr 19, 2013 at 11:52:10PM +0900, Jonghwan Choi wrote:
>From: Gavin Shan <shangw@linux.vnet.ibm.com>
>
>This patch looks like it should be in the 3.8-stable tree, should we apply
>it?
>

Yes, I think so. If possible, please apply to 3.8-stable.

Thanks,
Gavin

>------------------
>
>From: "Gavin Shan <shangw@linux.vnet.ibm.com>"
>
>commit d5dc0ad928fb9e972001e552597fd0b794863f34 upstream
>
>Fix the error return value in kswapd_run().  The bug was introduced by
>commit d5dc0ad928fb ("mm/vmscan: fix error number for failed kthread").
>
>Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
>Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>Reviewed-by: Rik van Riel <riel@redhat.com>
>Reported-by: Wu Fengguang <fengguang.wu@intel.com>
>Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
>---
> mm/vmscan.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/vmscan.c b/mm/vmscan.c
>index 196709f..8226b41 100644
>--- a/mm/vmscan.c
>+++ b/mm/vmscan.c
>@@ -3158,9 +3158,9 @@ int kswapd_run(int nid)
> 	if (IS_ERR(pgdat->kswapd)) {
> 		/* failure at boot is fatal */
> 		BUG_ON(system_state == SYSTEM_BOOTING);
>-		pgdat->kswapd = NULL;
> 		pr_err("Failed to start kswapd on node %d\n", nid);
> 		ret = PTR_ERR(pgdat->kswapd);
>+		pgdat->kswapd = NULL;
> 	}
> 	return ret;
> }
>-- 
>1.7.10.4
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>