Re: [PATCH] oom: add pending SIGKILL check for chosen victim

[Sergey Dyasly <dserrg@gmail.com>]

On Thu, 25 Apr 2013 16:49:55 +0200
Oleg Nesterov <oleg@redhat.com> wrote:

> On 04/24, Andrew Morton wrote:
> >
> > Where does this leave us with Sergey's patch?  "Still good, but
> > requires new changelog"?
> 
> Sergey is certainly right, this needs the fixes (thanks Sergey!).
> 
> But afaics the patch can't help, we need another solution.
> 
> Oleg.
> 

Oleg, thanks for your comments!

Indeed, my patch is intended for one particular case (OOM killer and
threadgroups). But in general case there is still a race, so my patch
should be reworked.

Still, I think that fatal_signal_pending() is a sensible check, since the one
for current task is already there, and there is a patch from David Rientjes
that does almost the same [1]. So maybe it's a general condition for not
invoking OOM killer but just setting TIF_MEMDIE for a task?

[1] - http://www.spinics.net/lists/linux-mm/msg54662.html

-- 
Sergey Dyasly <dserrg@gmail.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>