From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx198.postini.com [74.125.245.198]) by kanga.kvack.org (Postfix) with SMTP id 31F3B6B0032 for ; Wed, 15 May 2013 16:09:53 -0400 (EDT) Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 15 May 2013 14:09:52 -0600 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id D48926E8048 for ; Wed, 15 May 2013 16:09:45 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4FK9mLX316390 for ; Wed, 15 May 2013 16:09:48 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4FK9lQu005230 for ; Wed, 15 May 2013 16:09:48 -0400 Date: Wed, 15 May 2013 15:09:42 -0500 From: Seth Jennings Subject: Re: [PATCHv11 3/4] zswap: add to mm/ Message-ID: <20130515200942.GA17724@cerebellum> References: <1368448803-2089-1-git-send-email-sjenning@linux.vnet.ibm.com> <1368448803-2089-4-git-send-email-sjenning@linux.vnet.ibm.com> <15c5b1da-132a-4c9e-9f24-bc272d3865d5@default> <20130514163541.GC4024@medulla> <20130514225501.GA11956@cerebellum> <4d74f5db-11c1-4f58-97f4-8d96bbe601ac@default> <20130515185506.GA23342@phenom.dumpdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130515185506.GA23342@phenom.dumpdata.com> Sender: owner-linux-mm@kvack.org List-ID: To: Konrad Rzeszutek Wilk Cc: Dan Magenheimer , Andrew Morton , Greg Kroah-Hartman , Nitin Gupta , Minchan Kim , Robert Jennings , Jenifer Hopper , Mel Gorman , Johannes Weiner , Rik van Riel , Larry Woodman , Benjamin Herrenschmidt , Dave Hansen , Joe Perches , Joonsoo Kim , Cody P Schafer , Hugh Dickens , Paul Mackerras , linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org On Wed, May 15, 2013 at 02:55:06PM -0400, Konrad Rzeszutek Wilk wrote: > > Sorry, but I don't think that's appropriate for a patch in the MM subsystem. > > I am heading to the airport shortly so this email is a bit hastily typed. > > Perhaps a compromise can be reached where this code is merged as a driver > not a core mm component. There is a high bar to be in the MM - it has to > work with many many different configurations. > > And drivers don't have such a high bar. They just need to work on a specific > issue and that is it. If zswap ended up in say, drivers/mm that would make > it more palpable I think. > > Thoughts? zswap, the writeback code particularly, depends on a number of non-exported kernel symbols, namely: swapcache_free __swap_writepage __add_to_swap_cache swapcache_prepare swapper_spaces So it can't currently be built as a module and I'm not sure what the MM folks would think about exporting them and making them part of the KABI. Seth -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org