From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx153.postini.com [74.125.245.153]) by kanga.kvack.org (Postfix) with SMTP id 034746B0032 for ; Thu, 16 May 2013 09:18:07 -0400 (EDT) Date: Thu, 16 May 2013 15:18:04 +0200 From: Andrea Arcangeli Subject: Re: [PATCH] mm/THP: Use pmd_populate to update the pmd with pgtable_t pointer Message-ID: <20130516131804.GO5181@redhat.com> References: <1368347715-24597-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <871u9b56t2.fsf@linux.vnet.ibm.com> <20130513141357.GL27980@redhat.com> <87y5bj3pnc.fsf@linux.vnet.ibm.com> <87txm6537l.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87txm6537l.fsf@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, akpm@linux-foundation.org Hi Aneesh, On Mon, May 13, 2013 at 08:36:38PM +0530, Aneesh Kumar K.V wrote: > https://lists.ozlabs.org/pipermail/linuxppc-dev/2013-May/106406.html You need ACCESS_ONCE() in all "pgd = ACCESS_ONCE(*pgdp)", "pud = ACCESS_ONCE(*pudp)" otherwise the compiler could decide your change is a noop. I think you could remove the #ifdef CONFIG_TRANSPARENT_HUGEPAGE too. Thanks, Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org