From: Mel Gorman <mgorman@suse.de>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>,
Bob Liu <bob.liu@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
Konrad Wilk <konrad.wilk@oracle.com>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Jenifer Hopper <jhopper@us.ibm.com>,
Johannes Weiner <jweiner@redhat.com>,
Rik van Riel <riel@redhat.com>,
Larry Woodman <lwoodman@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Dave Hansen <dave@sr71.net>, Joe Perches <joe@perches.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Cody P Schafer <cody@linux.vnet.ibm.com>,
Hugh Dickens <hughd@google.com>,
Paul Mackerras <paulus@samba.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCHv11 3/4] zswap: add to mm/
Date: Fri, 17 May 2013 18:00:53 +0100 [thread overview]
Message-ID: <20130517170053.GQ11497@suse.de> (raw)
In-Reply-To: <b9131728-5cf8-4979-a6de-ac14cc409b28@default>
On Tue, May 14, 2013 at 09:37:08AM -0700, Dan Magenheimer wrote:
> > Can I get your ack on this pending the other changes?
>
> I'd like to hear Mel's feedback about this, but perhaps
> a compromise to allow for zswap merging would be to add
> something like the following to zswap's Kconfig comment:
>
I think there is a lot of ugly in there and potential for weird performance
bugs. I ran out of beans complaining about different parts during the
review but fixing it out of tree or in staging like it's been happening to
date has clearly not worked out at all. As starting points go, it could be
a hell of a lot worse. I do agree that it needs a big fat warning until
some of the ugly is beaten out of it. Requiring that it address all the
issues such as automatic pool sizing, NUMA issues, proper allocation prior
to merging will just end up with an unreviewable set of patches again so
lets just bite the bullet because at least there is a chance reviewers
can follow the incremental developments. Merging it to drivers will not
address anything IMO.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-17 17:00 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 12:39 [PATCHv11 0/4] zswap: compressed swap caching Seth Jennings
2013-05-13 12:40 ` [PATCHv11 1/4] debugfs: add get/set for atomic types Seth Jennings
2013-05-16 14:58 ` Rik van Riel
2013-05-13 12:40 ` [PATCHv11 2/4] zbud: add to mm/ Seth Jennings
2013-05-14 8:47 ` Bob Liu
2013-05-14 17:03 ` Seth Jennings
2013-05-16 15:30 ` Rik van Riel
2013-05-17 15:48 ` Mel Gorman
2013-05-19 20:52 ` Seth Jennings
2013-05-20 13:54 ` Mel Gorman
2013-05-20 15:42 ` Seth Jennings
2013-05-21 8:10 ` Mel Gorman
2013-05-23 2:00 ` Bob Liu
2013-05-23 9:52 ` Mel Gorman
2013-05-13 12:40 ` [PATCHv11 3/4] zswap: " Seth Jennings
2013-05-14 9:19 ` Bob Liu
2013-05-14 16:00 ` Seth Jennings
2013-05-14 16:37 ` Dan Magenheimer
2013-05-14 17:28 ` Seth Jennings
2013-05-14 20:54 ` Dan Magenheimer
2013-05-17 17:00 ` Mel Gorman [this message]
2013-05-16 17:16 ` Rik van Riel
2013-05-17 16:54 ` Mel Gorman
2013-05-19 23:33 ` Seth Jennings
2013-05-13 12:40 ` [PATCHv11 4/4] zswap: add documentation Seth Jennings
2013-05-16 17:06 ` Rik van Riel
2013-05-17 16:04 ` Mel Gorman
[not found] <<1368448803-2089-1-git-send-email-sjenning@linux.vnet.ibm.com>
[not found] ` <<1368448803-2089-3-git-send-email-sjenning@linux.vnet.ibm.com>
2013-05-13 15:43 ` [PATCHv11 2/4] zbud: add to mm/ Dan Magenheimer
2013-05-13 20:59 ` Seth Jennings
2013-05-16 15:30 ` Rik van Riel
[not found] ` <<1368448803-2089-4-git-send-email-sjenning@linux.vnet.ibm.com>
2013-05-13 22:31 ` [PATCHv11 3/4] zswap: " Dan Magenheimer
2013-05-14 16:35 ` Seth Jennings
2013-05-14 20:18 ` Dan Magenheimer
2013-05-14 22:55 ` Seth Jennings
2013-05-15 17:09 ` Dan Magenheimer
2013-05-15 18:55 ` Konrad Rzeszutek Wilk
2013-05-15 19:35 ` Dan Magenheimer
2013-05-15 20:45 ` Rik van Riel
2013-05-15 21:36 ` Dan Magenheimer
2013-05-15 22:01 ` Rik van Riel
2013-05-15 20:09 ` Seth Jennings
2013-05-15 20:24 ` Dave Hansen
2013-05-15 20:55 ` Dan Magenheimer
2013-05-15 20:45 ` Konrad Rzeszutek Wilk
2013-05-15 20:52 ` Dan Magenheimer
2013-05-15 22:14 ` Rik van Riel
2013-05-16 16:45 ` Dan Magenheimer
2013-05-16 17:06 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517170053.GQ11497@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bob.liu@oracle.com \
--cc=cody@linux.vnet.ibm.com \
--cc=dan.magenheimer@oracle.com \
--cc=dave@sr71.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jhopper@us.ibm.com \
--cc=joe@perches.com \
--cc=jweiner@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=paulus@samba.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).