From: Karel Zak <kzak@redhat.com>
To: Rafael Aquini <aquini@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, hughd@google.com, shli@kernel.org,
jmoyer@redhat.com, riel@redhat.com, lwoodman@redhat.com,
mgorman@suse.de
Subject: Re: [RFC PATCH 02/02] swapon: add "cluster-discard" support
Date: Tue, 21 May 2013 12:13:02 +0200 [thread overview]
Message-ID: <20130521101302.GA11774@x2.net.home> (raw)
In-Reply-To: <398ace0dd3ca1283372b3aad3fceeee59f6897d7.1369084886.git.aquini@redhat.com>
On Mon, May 20, 2013 at 09:04:25PM -0300, Rafael Aquini wrote:
> - while ((c = getopt_long(argc, argv, "ahdefp:svVL:U:",
> + while ((c = getopt_long(argc, argv, "ahcdefp:svVL:U:",
> long_opts, NULL)) != -1) {
> switch (c) {
> case 'a': /* all */
> @@ -738,8 +753,11 @@ int main(int argc, char *argv[])
> case 'U':
> add_uuid(optarg);
> break;
> + case 'c':
> + discard += 2;
> + break;
> case 'd':
> - discard = 1;
> + discard += 1;
this is fragile, it would be better to use
case 'c':
discard |= SWAP_FLAG_DISCARD_CLUSTER;
break;
case 'd':
discard |= SWAP_FLAG_DISCARD;
break;
and use directly the flags everywhere in the code than use magical
numbers '1' and '2' etc.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-05-21 10:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 0:04 [RFC PATCH 00/02] swap: allowing a more flexible DISCARD policy Rafael Aquini
2013-05-21 0:04 ` [RFC PATCH 01/02] swap: discard while swapping only if SWAP_FLAG_DISCARD_CLUSTER Rafael Aquini
2013-05-21 0:55 ` KOSAKI Motohiro
2013-05-21 21:06 ` Rafael Aquini
2013-05-21 0:04 ` [RFC PATCH 02/02] swapon: add "cluster-discard" support Rafael Aquini
2013-05-21 1:02 ` KOSAKI Motohiro
2013-05-21 10:26 ` Karel Zak
2013-05-21 20:17 ` KOSAKI Motohiro
2013-05-21 21:13 ` Rafael Aquini
2013-05-21 22:01 ` KOSAKI Motohiro
2013-05-22 13:52 ` Jeff Moyer
2013-05-21 10:13 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130521101302.GA11774@x2.net.home \
--to=kzak@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=hughd@google.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).