From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx146.postini.com [74.125.245.146]) by kanga.kvack.org (Postfix) with SMTP id 3FCAF6B00D6 for ; Wed, 22 May 2013 11:10:37 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-34-git-send-email-kirill.shutemov@linux.intel.com> Subject: Re: [PATCHv4 33/39] thp, mm: implement do_huge_linear_fault() Content-Transfer-Encoding: 7bit Message-Id: <20130522151302.24420E0090@blue.fi.intel.com> Date: Wed, 22 May 2013 18:13:02 +0300 (EEST) Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Dave Hansen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Hillf Danton wrote: > On Sun, May 12, 2013 at 9:23 AM, Kirill A. Shutemov > wrote: > > @@ -3301,12 +3335,23 @@ static int __do_fault(struct mm_struct *mm, struct vm_area_struct *vma, > > { > > pte_t *page_table; > > spinlock_t *ptl; > > + pgtable_t pgtable = NULL; > > struct page *page, *cow_page, *dirty_page = NULL; > > - pte_t entry; > > bool anon = false, page_mkwrite = false; > > bool write = flags & FAULT_FLAG_WRITE; > > + bool thp = flags & FAULT_FLAG_TRANSHUGE; > > + unsigned long addr_aligned; > > struct vm_fault vmf; > > - int ret; > > + int nr, ret; > > + > > + if (thp) { > > + if (!transhuge_vma_suitable(vma, address)) > > + return VM_FAULT_FALLBACK; > > + if (unlikely(khugepaged_enter(vma))) > > vma->vm_mm now is under the care of khugepaged, why? Because it has at least once VMA suitable for huge pages. Yes, we can't collapse pages in file-backed VMAs yet, but It's better to be consistent to avoid issues when collapsing will be implemented. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org