From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Jiang Liu <jiang.liu@huawei.com>,
Tang Chen <tangchen@cn.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] mm/hugetlb: use already exist interface huge_page_shift
Date: Thu, 23 May 2013 07:40:19 +0800 [thread overview]
Message-ID: <20130522234019.GB13972@hacker.(null)> (raw)
In-Reply-To: <20130522105246.GF19989@dhcp22.suse.cz>
On Wed, May 22, 2013 at 12:52:46PM +0200, Michal Hocko wrote:
>On Wed 22-05-13 17:29:30, Wanpeng Li wrote:
>> Use already exist interface huge_page_shift instead of h->order + PAGE_SHIFT.
>
>alloc_bootmem_huge_page in powerpc uses the same construct so maybe you
>want to udpate that one as well.
>
I will add this, thanks Michal, ;-)
>>
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>
>Reviewed-by: Michal Hocko <mhocko@suse.cz>
>
>> ---
>> mm/hugetlb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
>> index f8feeec..b6ff0ee 100644
>> --- a/mm/hugetlb.c
>> +++ b/mm/hugetlb.c
>> @@ -319,7 +319,7 @@ unsigned long vma_kernel_pagesize(struct vm_area_struct *vma)
>>
>> hstate = hstate_vma(vma);
>>
>> - return 1UL << (hstate->order + PAGE_SHIFT);
>> + return 1UL << huge_page_shift(hstate);
>> }
>> EXPORT_SYMBOL_GPL(vma_kernel_pagesize);
>>
>> --
>> 1.8.1.2
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
>--
>Michal Hocko
>SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-22 23:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 9:29 [PATCH 1/4] mm/memory-hotplug: fix lowmem count overflow when offline pages Wanpeng Li
2013-05-22 9:29 ` [PATCH 2/4] mm/pageblock: remove get/set_pageblock_flags Wanpeng Li
2013-05-22 10:50 ` Michal Hocko
2013-05-22 9:29 ` [PATCH 3/4] mm/hugetlb: remove hugetlb_prefault Wanpeng Li
2013-05-22 10:50 ` Michal Hocko
2013-05-22 9:29 ` [PATCH 4/4] mm/hugetlb: use already exist interface huge_page_shift Wanpeng Li
2013-05-22 10:52 ` Michal Hocko
2013-05-22 23:40 ` Wanpeng Li
2013-05-22 23:40 ` Wanpeng Li [this message]
2013-05-22 10:49 ` [PATCH 1/4] mm/memory-hotplug: fix lowmem count overflow when offline pages Michal Hocko
2013-05-22 23:38 ` Wanpeng Li
2013-05-22 23:38 ` Wanpeng Li
2013-05-30 8:20 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130522234019.GB13972@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=jiang.liu@huawei.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).