From: Vivek Goyal <vgoyal@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
ebiederm@xmission.com, cpw@sgi.com,
kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
zhangyanfei@cn.fujitsu.com, jingbai.ma@hp.com,
linux-mm@kvack.org, riel@redhat.com, walken@google.com,
hughd@google.com, kosaki.motohiro@jp.fujitsu.com
Subject: Re: [PATCH v8 3/9] vmcore: treat memory chunks referenced by PT_LOAD program header entries in page-size boundary in vmcore_list
Date: Fri, 24 May 2013 09:12:17 -0400 [thread overview]
Message-ID: <20130524131217.GA18218@redhat.com> (raw)
In-Reply-To: <20130523144928.0328bb3ad7ccc1ff2da9558d@linux-foundation.org>
On Thu, May 23, 2013 at 02:49:28PM -0700, Andrew Morton wrote:
> On Thu, 23 May 2013 14:25:13 +0900 HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:
>
> > Treat memory chunks referenced by PT_LOAD program header entries in
> > page-size boundary in vmcore_list. Formally, for each range [start,
> > end], we set up the corresponding vmcore object in vmcore_list to
> > [rounddown(start, PAGE_SIZE), roundup(end, PAGE_SIZE)].
> >
> > This change affects layout of /proc/vmcore.
>
> Well, changing a userspace interface is generally unacceptable because
> it can break existing userspace code.
>
> If you think the risk is acceptable then please do explain why. In
> great detail!
I think it should not be a problem as /proc/vmcore is useful only when
one parses the elf headers and then accesses the contents of file based
on the header information. This patch just introduces additional areas
in /proc/vmcore file and ELF headers still point to right contents. So
any tool parsing ELF headers and then accessing file contents based on
that info should still be fine.
AFAIK, no user space tool should be broken there.
Thanks
Vivek
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-24 13:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 5:24 [PATCH v8 0/9] kdump, vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-05-23 5:25 ` [PATCH v8 1/9] vmcore: clean up read_vmcore() HATAYAMA Daisuke
2013-05-23 5:25 ` [PATCH v8 2/9] vmcore: allocate buffer for ELF headers on page-size alignment HATAYAMA Daisuke
2013-05-23 14:22 ` Vivek Goyal
2013-05-23 21:46 ` Andrew Morton
2013-05-23 5:25 ` [PATCH v8 3/9] vmcore: treat memory chunks referenced by PT_LOAD program header entries in page-size boundary in vmcore_list HATAYAMA Daisuke
2013-05-23 21:49 ` Andrew Morton
2013-05-24 13:12 ` Vivek Goyal [this message]
2013-05-27 0:13 ` HATAYAMA Daisuke
2013-05-23 5:25 ` [PATCH v8 4/9] vmalloc: make find_vm_area check in range HATAYAMA Daisuke
2013-05-23 5:25 ` [PATCH v8 5/9] vmalloc: introduce remap_vmalloc_range_partial HATAYAMA Daisuke
2013-05-23 22:00 ` Andrew Morton
2013-05-23 5:25 ` [PATCH v8 6/9] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory HATAYAMA Daisuke
2013-05-23 14:28 ` Vivek Goyal
2013-05-23 22:17 ` Andrew Morton
2013-05-23 5:25 ` [PATCH v8 7/9] vmcore: Allow user process to remap ELF note segment buffer HATAYAMA Daisuke
2013-05-23 14:32 ` Vivek Goyal
2013-05-23 5:25 ` [PATCH v8 8/9] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects HATAYAMA Daisuke
2013-05-23 14:34 ` Vivek Goyal
2013-05-23 5:25 ` [PATCH v8 9/9] vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-05-23 22:24 ` Andrew Morton
2013-05-24 9:02 ` Maxim Uvarov
2013-05-27 1:49 ` HATAYAMA Daisuke
2013-05-30 9:14 ` Maxim Uvarov
2013-05-30 9:26 ` Zhang Yanfei
2013-05-30 10:30 ` Maxim Uvarov
2013-06-03 8:43 ` Atsushi Kumagai
2013-06-04 15:34 ` Maxim Uvarov
2013-06-07 1:11 ` Zhang Yanfei
2013-06-28 16:40 ` Maxim Uvarov
2013-06-30 23:53 ` HATAYAMA Daisuke
2013-07-01 14:34 ` Maxim Uvarov
2013-07-01 19:53 ` Andrew Morton
2013-07-02 7:00 ` Maxim Uvarov
2013-06-06 21:31 ` Arnd Bergmann
2013-06-07 1:01 ` HATAYAMA Daisuke
2013-06-07 18:34 ` Arnd Bergmann
2013-06-08 10:42 ` HATAYAMA Daisuke
2013-05-23 14:35 ` [PATCH v8 0/9] kdump, " Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524131217.GA18218@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cpw@sgi.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=ebiederm@xmission.com \
--cc=hughd@google.com \
--cc=jingbai.ma@hp.com \
--cc=kexec@lists.infradead.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lisa.mitchell@hp.com \
--cc=riel@redhat.com \
--cc=walken@google.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).