linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Sergey Dyasly <dserrg@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.cz>,
	linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Sha Zhengju <handai.szj@taobao.com>
Subject: Re: [PATCH] oom: add pending SIGKILL check for chosen victim
Date: Mon, 27 May 2013 18:16:18 +0200	[thread overview]
Message-ID: <20130527161618.GA804@redhat.com> (raw)
In-Reply-To: <20130527194915.493c1bed1de8f62e7e382164@gmail.com>

Hi Sergey,

Cough... I hoped that I will send at least some changes before another
reminder, but I am late again ;)

On 05/27, Sergey Dyasly wrote:
>
> Adding thread_head into task_struct->signal would be the best solution imho.
> This way list will be properly protected by rcu_read_lock(). But you called it
> "really painful". I guess that's because all users of while_each_thread(g, t)
> must be modified with 'g' pointing to the new thread_head. And I've counted
> 50 usages of while_each_thread() across the kernel.

Plus sometimes we need to iterate the group starting from non-leader.
And we need to keep both old/new lists before we convert all users,
and some other complications.

I hope I'll send some preparational patches today, I have already started
this (today ;).

Oleg.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2013-05-27 16:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 15:06 [PATCH] oom: add pending SIGKILL check for chosen victim Sergey Dyasly
2013-04-22 19:51 ` Michal Hocko
2013-04-23 15:26   ` dserrg
2013-04-23 15:56     ` Michal Hocko
2013-04-24 14:55       ` Oleg Nesterov
2013-04-24 15:22         ` Michal Hocko
2013-04-24 15:42           ` Oleg Nesterov
2013-04-24 19:33             ` Andrew Morton
2013-04-25 14:49               ` Oleg Nesterov
2013-04-25 15:41                 ` Sergey Dyasly
2013-04-25 16:22                   ` Oleg Nesterov
2013-05-02 17:20                     ` Oleg Nesterov
2013-05-27 15:49                       ` Sergey Dyasly
2013-05-27 16:16                         ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130527161618.GA804@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dserrg@gmail.com \
    --cc=handai.szj@taobao.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).