From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx130.postini.com [74.125.245.130]) by kanga.kvack.org (Postfix) with SMTP id 81A606B0031 for ; Wed, 5 Jun 2013 22:48:16 -0400 (EDT) Date: Wed, 5 Jun 2013 19:48:01 -0700 From: Andrew Morton Subject: Re: [PATCH v10 03/35] dcache: convert dentry_stat.nr_unused to per-cpu counters Message-Id: <20130605194801.f9b25abf.akpm@linux-foundation.org> In-Reply-To: <20130606014509.GN29338@dastard> References: <1370287804-3481-1-git-send-email-glommer@openvz.org> <1370287804-3481-4-git-send-email-glommer@openvz.org> <20130605160731.91a5cd3ff700367f5e155d83@linux-foundation.org> <20130606014509.GN29338@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Dave Chinner Cc: Glauber Costa , linux-fsdevel@vger.kernel.org, Mel Gorman , linux-mm@kvack.org, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, Michal Hocko , Johannes Weiner , hughd@google.com, Greg Thelen , Dave Chinner On Thu, 6 Jun 2013 11:45:09 +1000 Dave Chinner wrote: > Andrew, if you want to push the changes back to generic per-cpu > counters through to Linus, then I'll write the patches for you. But > - and this is a big but - I'll only do this if you are going to deal > with the "performance trumps all other concerns" fanatics over > whether it should be merged or not. I have better things to do > with my time have a flamewar over trivial details like this. Please view my comments as a critique of the changelog, not of the code. There are presumably good (but undisclosed) reasons for going this way, but this question is so bleeding obvious that the decision should have been addressed up-front and in good detail. And, preferably, with benchmark numbers. Because it might have been the wrong decision - stranger things have happened. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org