linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [patch -mm] mm, vmalloc: unbreak __vunmap()
@ 2013-06-07 12:07 Dan Carpenter
  2013-06-07 15:56 ` Zhang Yanfei
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-06-07 12:07 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Joonsoo Kim, Zhang Yanfei, David Rientjes, KOSAKI Motohiro,
	linux-mm, linux-kernel, kernel-janitors

There is an extra semi-colon so the function always returns.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 91a1047..96b77a9 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1453,7 +1453,7 @@ static void __vunmap(const void *addr, int deallocate_pages)
 		return;
 
 	if (WARN(!PAGE_ALIGNED(addr), "Trying to vfree() bad address (%p)\n",
-			addr));
+			addr))
 		return;
 
 	area = remove_vm_area(addr);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch -mm] mm, vmalloc: unbreak __vunmap()
  2013-06-07 12:07 [patch -mm] mm, vmalloc: unbreak __vunmap() Dan Carpenter
@ 2013-06-07 15:56 ` Zhang Yanfei
  0 siblings, 0 replies; 2+ messages in thread
From: Zhang Yanfei @ 2013-06-07 15:56 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Andrew Morton, Joonsoo Kim, Zhang Yanfei, David Rientjes,
	KOSAKI Motohiro, linux-mm, linux-kernel, kernel-janitors

On 06/07/2013 08:07 PM, Dan Carpenter wrote:
> There is an extra semi-colon so the function always returns.

Acked-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>

This is imported by using the macro PAGE_ALIGNED.

> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 91a1047..96b77a9 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1453,7 +1453,7 @@ static void __vunmap(const void *addr, int deallocate_pages)
>  		return;
>  
>  	if (WARN(!PAGE_ALIGNED(addr), "Trying to vfree() bad address (%p)\n",
> -			addr));
> +			addr))
>  		return;
>  
>  	area = remove_vm_area(addr);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-07 15:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-07 12:07 [patch -mm] mm, vmalloc: unbreak __vunmap() Dan Carpenter
2013-06-07 15:56 ` Zhang Yanfei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).