linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [patch -mm] UBIFS: signedness bug in ubifs_shrink_count()
@ 2013-06-11  7:13 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2013-06-11  7:13 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Dave Chinner, Glauber Costa, linux-mm

We test "clean_zn_cnt" for negative later in the function.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This was introduced in the -mm branch in:
fs-convert-fs-shrinkers-to-new-scan-count-api-fix

diff --git a/fs/ubifs/shrinker.c b/fs/ubifs/shrinker.c
index 68ce399..f35135e 100644
--- a/fs/ubifs/shrinker.c
+++ b/fs/ubifs/shrinker.c
@@ -280,7 +280,7 @@ static int kick_a_thread(void)
 unsigned long ubifs_shrink_count(struct shrinker *shrink,
 				 struct shrink_control *sc)
 {
-	unsigned long clean_zn_cnt = atomic_long_read(&ubifs_clean_zn_cnt);
+	long clean_zn_cnt = atomic_long_read(&ubifs_clean_zn_cnt);
 
 	/*
 	 * Due to the way UBIFS updates the clean znode counter it may

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-06-11  7:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-11  7:13 [patch -mm] UBIFS: signedness bug in ubifs_shrink_count() Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).