From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Rik van Riel <riel@redhat.com>,
Andrew Shewmaker <agshew@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Namjae Jeon <linkinjeon@gmail.com>,
Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/7] mm/page_alloc: fix blank in show_free_areas
Date: Mon, 17 Jun 2013 17:50:36 +0800 [thread overview]
Message-ID: <20130617095036.GB21564@hacker.(null)> (raw)
In-Reply-To: <20130617081012.GA19194@dhcp22.suse.cz>
On Mon, Jun 17, 2013 at 10:10:12AM +0200, Michal Hocko wrote:
>On Sun 16-06-13 09:14:47, Wanpeng Li wrote:
>> There is a blank in show_free_areas which lead to dump messages aren't
>> aligned. This patch remove blank.
>>
>> Before patch:
>>
>> [155219.720141] active_anon:50675 inactive_anon:35273 isolated_anon:0
>> [155219.720141] active_file:215421 inactive_file:344268 isolated_file:0
>> [155219.720141] unevictable:0 dirty:35 writeback:0 unstable:0
>> [155219.720141] free:1334870 slab_reclaimable:28833 slab_unreclaimable:5115
>> [155219.720141] mapped:25233 shmem:35511 pagetables:1705 bounce:0
>> [155219.720141] free_cma:0
>>
>> After patch:
>>
>> [ 73.913889] active_anon:39578 inactive_anon:32082 isolated_anon:0
>> [ 73.913889] active_file:14621 inactive_file:57993 isolated_file:0
>> [ 73.913889] unevictable:0dirty:263 writeback:0 unstable:0
>> [ 73.913889] free:1865614 slab_reclaimable:3264 slab_unreclaimable:4566
>> [ 73.913889] mapped:21192 shmem:32327 pagetables:1572 bounce:0
>> [ 73.913889] free_cma:0
>
>Not that I would care much but this format is here for ages. An
>additional space was kind of nice to visually separate this part from
>the per-zone data.
>
>Is there any special reason for this change?
>
No special reason, I'm ok if you prefer the old format. ;-)
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>> ---
>> mm/page_alloc.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 18102e1..e6e881a 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -3004,12 +3004,12 @@ void show_free_areas(unsigned int filter)
>> }
>>
>> printk("active_anon:%lu inactive_anon:%lu isolated_anon:%lu\n"
>> - " active_file:%lu inactive_file:%lu isolated_file:%lu\n"
>> - " unevictable:%lu"
>> - " dirty:%lu writeback:%lu unstable:%lu\n"
>> - " free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n"
>> - " mapped:%lu shmem:%lu pagetables:%lu bounce:%lu\n"
>> - " free_cma:%lu\n",
>> + "active_file:%lu inactive_file:%lu isolated_file:%lu\n"
>> + "unevictable:%lu"
>> + "dirty:%lu writeback:%lu unstable:%lu\n"
>
>There is a space missing between unevictable and dirty.
Oh, I miss that. Thanks for pointing out. ;-)
Regards,
Wanpeng Li
>
>> + "free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n"
>> + "mapped:%lu shmem:%lu pagetables:%lu bounce:%lu\n"
>> + "free_cma:%lu\n",
>> global_page_state(NR_ACTIVE_ANON),
>> global_page_state(NR_INACTIVE_ANON),
>> global_page_state(NR_ISOLATED_ANON),
>
>--
>Michal Hocko
>SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-17 9:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 1:14 [PATCH v2 1/7] mm/writeback: remove wb_reason_name Wanpeng Li
2013-06-16 1:14 ` [PATCH v2 2/7] mm/writeback: Don't check force_wait to handle bdi->work_list Wanpeng Li
2013-06-16 1:14 ` [PATCH v2 3/7] mm/writeback: commit reason of WB_REASON_FORKER_THREAD mismatch name Wanpeng Li
2013-06-17 8:30 ` Michal Hocko
2013-06-17 9:41 ` Wanpeng Li
2013-06-17 9:41 ` Wanpeng Li
[not found] ` <51bed9eb.41e9420a.2725.ffff943cSMTPIN_ADDED_BROKEN@mx.google.com>
2013-06-17 20:27 ` Tejun Heo
2013-06-16 1:14 ` [PATCH v2 4/7] mm/page_alloc: fix blank in show_free_areas Wanpeng Li
2013-06-17 8:10 ` Michal Hocko
2013-06-17 9:50 ` Wanpeng Li [this message]
2013-06-17 9:50 ` Wanpeng Li
2013-06-16 1:14 ` [PATCH v2 5/7] mm/page_alloc: fix doc for numa_zonelist_order Wanpeng Li
2013-06-17 8:17 ` Michal Hocko
2013-06-16 1:14 ` [PATCH v2 6/7] mm/thp: fix doc for transparent huge zero page Wanpeng Li
2013-06-16 1:14 ` [PATCH v2 7/7] mm/pgtable: Don't accumulate addr during pgd prepopulate pmd Wanpeng Li
2013-06-17 8:20 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130617095036.GB21564@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=agshew@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=jkosina@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).