From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx158.postini.com [74.125.245.158]) by kanga.kvack.org (Postfix) with SMTP id 33A6E6B0034 for ; Mon, 17 Jun 2013 09:30:51 -0400 (EDT) Date: Mon, 17 Jun 2013 15:30:49 +0200 From: Michal Hocko Subject: Re: [PATCH v2 0/2] slightly rework memcg cache id determination Message-ID: <20130617133049.GC5018@dhcp22.suse.cz> References: <1371233076-936-1-git-send-email-glommer@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1371233076-936-1-git-send-email-glommer@openvz.org> Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: linux-mm , cgroups , Johannes Weiner , Andrew Morton , Kamezawa Hiroyuki , Glauber Costa On Fri 14-06-13 14:04:34, Glauber Costa wrote: > Michal, > > Let me know if this is more acceptable to you. I didn't take your suggestion of > having an id and idx functions, because I think this could potentially be even > more confusing: in the sense that people would need to wonder a bit what is the > difference between them. Any clean up is better than nothing. I still think that split up and making the 2 functions explicit would be better but I do not think this is really that important. > Note please that we never use the id as an array index outside of memcg core. Now but that doesn't prevent future abuse. > So for memcg core, I have changed, in Patch 2, each direct use of idx as an > index to include a VM_BUG_ON in case we would get an invalid index. OK. If you had an _idx variant then you wouldn't need to add that VM_BUG_ON at every single place where you use it as an index and do not risk that future calls would forget about VM_BUG_ON. > For the other cases, I have consolidated a bit the usage pattern around > memcg_cache_id. Now the tests are all pretty standardized. OK, Great! > Glauber Costa (2): > memcg: make cache index determination more robust > memcg: consolidate callers of memcg_cache_id > > mm/memcontrol.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > -- > 1.8.1.4 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org