From: Tejun Heo <tj@kernel.org>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Michal Hocko <mhocko@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Rik van Riel <riel@redhat.com>,
Andrew Shewmaker <agshew@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Namjae Jeon <linkinjeon@gmail.com>,
Jan Kara <jack@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] mm/writeback: commit reason of WB_REASON_FORKER_THREAD mismatch name
Date: Mon, 17 Jun 2013 13:27:06 -0700 [thread overview]
Message-ID: <20130617202706.GM32663@mtj.dyndns.org> (raw)
In-Reply-To: <51bed9eb.41e9420a.2725.ffff943cSMTPIN_ADDED_BROKEN@mx.google.com>
On Mon, Jun 17, 2013 at 05:41:44PM +0800, Wanpeng Li wrote:
> On Mon, Jun 17, 2013 at 10:30:30AM +0200, Michal Hocko wrote:
> >On Sun 16-06-13 09:14:46, Wanpeng Li wrote:
> >> After commit 839a8e86("writeback: replace custom worker pool implementation
> >> with unbound workqueue"), there is no bdi forker thread any more. However,
> >> WB_REASON_FORKER_THREAD is still used due to it is somewhat userland visible
> >
> >What exactly "somewhat userland visible" means?
> >Is this about trace events?
>
> Thanks for the question, Tejun, could you explain this for us? ;-)
Yeah, I was referring to the WB_REASON strings in
include/trace/events/writeback.h. We can rename the internal constant
and leave the string alone too but I don't think it matters either
way.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-17 20:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 1:14 [PATCH v2 1/7] mm/writeback: remove wb_reason_name Wanpeng Li
2013-06-16 1:14 ` [PATCH v2 2/7] mm/writeback: Don't check force_wait to handle bdi->work_list Wanpeng Li
2013-06-16 1:14 ` [PATCH v2 3/7] mm/writeback: commit reason of WB_REASON_FORKER_THREAD mismatch name Wanpeng Li
2013-06-17 8:30 ` Michal Hocko
2013-06-17 9:41 ` Wanpeng Li
2013-06-17 9:41 ` Wanpeng Li
[not found] ` <51bed9eb.41e9420a.2725.ffff943cSMTPIN_ADDED_BROKEN@mx.google.com>
2013-06-17 20:27 ` Tejun Heo [this message]
2013-06-16 1:14 ` [PATCH v2 4/7] mm/page_alloc: fix blank in show_free_areas Wanpeng Li
2013-06-17 8:10 ` Michal Hocko
2013-06-17 9:50 ` Wanpeng Li
2013-06-17 9:50 ` Wanpeng Li
2013-06-16 1:14 ` [PATCH v2 5/7] mm/page_alloc: fix doc for numa_zonelist_order Wanpeng Li
2013-06-17 8:17 ` Michal Hocko
2013-06-16 1:14 ` [PATCH v2 6/7] mm/thp: fix doc for transparent huge zero page Wanpeng Li
2013-06-16 1:14 ` [PATCH v2 7/7] mm/pgtable: Don't accumulate addr during pgd prepopulate pmd Wanpeng Li
2013-06-17 8:20 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617202706.GM32663@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=agshew@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=jkosina@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).