linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.cz>,
	David Rientjes <rientjes@google.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Rik van Riel <riel@redhat.com>,
	Andrew Shewmaker <agshew@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>, Namjae Jeon <linkinjeon@gmail.com>,
	Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/6] mm/writeback: commit reason of WB_REASON_FORKER_THREAD mismatch name
Date: Thu, 20 Jun 2013 21:57:19 +0800	[thread overview]
Message-ID: <20130620135719.GB10909@localhost> (raw)
In-Reply-To: <1371599563-6424-3-git-send-email-liwanp@linux.vnet.ibm.com>

> @@ -47,6 +47,11 @@ enum wb_reason {
>  	WB_REASON_LAPTOP_TIMER,
>  	WB_REASON_FREE_MORE_MEM,
>  	WB_REASON_FS_FREE_SPACE,
> +/*
> + * There is no bdi forker thread any more and works are done by emergency
> + * worker, however, this is TPs userland visible and we'll be exposing
> + * exactly the same information, so it has a mismatch name.
> + */

Nitpick: indent the comment.

>  	WB_REASON_FORKER_THREAD,
>  
>  	WB_REASON_MAX,

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-06-20 13:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18 23:52 [PATCH v4 1/6] mm/writeback: remove wb_reason_name Wanpeng Li
2013-06-18 23:52 ` [PATCH v4 2/6] mm/writeback: Don't check force_wait to handle bdi->work_list Wanpeng Li
2013-06-20 13:46   ` Fengguang Wu
2013-06-20 23:37     ` Wanpeng Li
2013-06-20 23:37     ` Wanpeng Li
2013-06-21  0:31       ` Fengguang Wu
2013-06-18 23:52 ` [PATCH v4 3/6] mm/writeback: commit reason of WB_REASON_FORKER_THREAD mismatch name Wanpeng Li
2013-06-20 13:57   ` Fengguang Wu [this message]
2013-06-20 23:39     ` Wanpeng Li
2013-06-20 23:39     ` Wanpeng Li
2013-06-18 23:52 ` [PATCH v4 4/6] mm/page_alloc: fix doc for numa_zonelist_order Wanpeng Li
2013-06-18 23:52 ` [PATCH v4 5/6] mm/thp: fix doc for transparent huge zero page Wanpeng Li
2013-06-18 23:52 ` [PATCH v4 6/6] mm/pgtable: Don't accumulate addr during pgd prepopulate pmd Wanpeng Li
2013-06-19  1:31   ` Zhang Yanfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130620135719.GB10909@localhost \
    --to=fengguang.wu@intel.com \
    --cc=agshew@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=jkosina@suse.cz \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linkinjeon@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liwanp@linux.vnet.ibm.com \
    --cc=mhocko@suse.cz \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).