From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Dave Chinner <david@fromorbit.com>,
andi@firstfloor.org, Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Chris.mason@fusionio.com, jbacik@fusionio.com,
Ben Myers <bpm@sgi.com>,
tytso@mit.edu, hughd@google.com, Mark Fasheh <mfasheh@suse.com>,
Joel Becker <jlbec@evilplan.org>,
sage@inktank.com
Subject: Re: [PATCH v2] vfs: export lseek_execute() to modules
Date: Tue, 25 Jun 2013 08:11:40 +0100 [thread overview]
Message-ID: <20130625071139.GZ4165@ZenIV.linux.org.uk> (raw)
In-Reply-To: <51C91645.8050502@oracle.com>
On Tue, Jun 25, 2013 at 12:02:13PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> For those file systems(btrfs/ext4/ocfs2/tmpfs) that support
> SEEK_DATA/SEEK_HOLE functions, we end up handling the similar
> matter in lseek_execute() to update the current file offset
> to the desired offset if it is valid, ceph also does the
> simliar things at ceph_llseek().
>
> To reduce the duplications, this patch make lseek_execute()
> public accessible so that we can call it directly from the
> underlying file systems.
Umm... I like it, but it needs changes:
* inode argument of lseek_execute() is pointless (and killed
off in vfs.git, actually)
* I'm really not happy about the name of that function. For
a static it's kinda-sort tolerable, but for something global, let
alone exported...
I've put a modified variant into #for-next; could you check if you are
still OK with it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-25 7:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 4:02 [PATCH v2] vfs: export lseek_execute() to modules Jeff Liu
2013-06-25 7:11 ` Al Viro [this message]
2013-06-25 7:48 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625071139.GZ4165@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Chris.mason@fusionio.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jbacik@fusionio.com \
--cc=jeff.liu@oracle.com \
--cc=jlbec@evilplan.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mfasheh@suse.com \
--cc=sage@inktank.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).