From: Oleg Nesterov <oleg@redhat.com>
To: Valdis.Kletnieks@vt.edu
Cc: Randy Dunlap <rdunlap@infradead.org>,
akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: mmotm 2013-06-27-16-36 uploaded (wait event common)
Date: Sun, 30 Jun 2013 20:28:37 +0200 [thread overview]
Message-ID: <20130630182837.GA5738@redhat.com> (raw)
In-Reply-To: <65029.1372514416@turing-police.cc.vt.edu>
On 06/29, Valdis.Kletnieks@vt.edu wrote:
>
> On Thu, 27 Jun 2013 22:30:41 -0700, Randy Dunlap said:
>
> > + __ret = __wait_no_timeout(tout) ?: (tout) ?: 1;
>
> Was this trying to do a wait_ho_timeout(!!tout) or something?
No, __wait_no_timeout() means that tout == MAX_SCHEDULE_TIMEOUT.
But the logic is wrong, we should return zero in this case.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-06-30 18:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 23:37 mmotm 2013-06-27-16-36 uploaded akpm
2013-06-27 23:57 ` Stephen Rothwell
2013-06-28 0:32 ` Andrew Morton
2013-06-28 1:09 ` Stephen Rothwell
2013-06-28 5:30 ` mmotm 2013-06-27-16-36 uploaded (wait event common) Randy Dunlap
2013-06-28 5:51 ` Andrew Morton
2013-06-28 6:06 ` Randy Dunlap
2013-06-28 6:56 ` Stephen Rothwell
2013-06-28 15:38 ` Oleg Nesterov
2013-06-28 17:15 ` Oleg Nesterov
2013-06-29 14:00 ` Valdis.Kletnieks
2013-06-30 18:28 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130630182837.GA5738@redhat.com \
--to=oleg@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).