From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx128.postini.com [74.125.245.128]) by kanga.kvack.org (Postfix) with SMTP id 215E96B0036 for ; Thu, 4 Jul 2013 05:25:04 -0400 (EDT) Date: Thu, 4 Jul 2013 10:25:00 +0100 From: Mel Gorman Subject: Re: [PATCH 09/13] sched: Favour moving tasks towards nodes that incurred more faults Message-ID: <20130704092500.GL1875@suse.de> References: <1372861300-9973-1-git-send-email-mgorman@suse.de> <1372861300-9973-10-git-send-email-mgorman@suse.de> <20130703182748.GA18898@dyad.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20130703182748.GA18898@dyad.programming.kicks-ass.net> Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: Srikar Dronamraju , Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML On Wed, Jul 03, 2013 at 08:27:48PM +0200, Peter Zijlstra wrote: > On Wed, Jul 03, 2013 at 03:21:36PM +0100, Mel Gorman wrote: > > static bool migrate_improves_locality(struct task_struct *p, struct lb_env *env) > > { > > > + if (p->numa_faults[task_faults_idx(dst_nid, 1)] > > > + p->numa_faults[task_faults_idx(src_nid, 1)]) > > + return true; > > > +} > > > +static bool migrate_degrades_locality(struct task_struct *p, struct lb_env *env) > > +{ > > > + if (p->numa_faults[src_nid] > p->numa_faults[dst_nid]) > > return true; > > I bet you wanted to use task_faults_idx() there too ;-) > You won that bet. Fixed. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org