From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx104.postini.com [74.125.245.104]) by kanga.kvack.org (Postfix) with SMTP id BD12B6B0033 for ; Thu, 4 Jul 2013 10:40:23 -0400 (EDT) Date: Thu, 4 Jul 2013 15:40:18 +0100 From: Mel Gorman Subject: Re: [PATCH 13/13] sched: Account for the number of preferred tasks running on a node when selecting a preferred node Message-ID: <20130704144018.GS1875@suse.de> References: <1372861300-9973-1-git-send-email-mgorman@suse.de> <1372861300-9973-14-git-send-email-mgorman@suse.de> <20130703183243.GB18898@dyad.programming.kicks-ass.net> <20130704093716.GO1875@suse.de> <20130704130719.GC29916@linux.vnet.ibm.com> <20130704135415.GR1875@suse.de> <20130704140612.GO18898@dyad.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20130704140612.GO18898@dyad.programming.kicks-ass.net> Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: Srikar Dronamraju , Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML On Thu, Jul 04, 2013 at 04:06:13PM +0200, Peter Zijlstra wrote: > On Thu, Jul 04, 2013 at 02:54:15PM +0100, Mel Gorman wrote: > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index 9247345..387f28d 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -863,9 +863,13 @@ find_idlest_cpu_node(int this_cpu, int nid) > > load = weighted_cpuload(i); > > > > if (load < min_load) { > > - /* Do not preempt a task running on a preferred node */ > > + /* > > + * Do not preempt a task running on a preferred node or > > + * tasks are are pinned to their current CPU > > + */ > > struct task_struct *p = cpu_rq(i)->curr; > > - if (p->numa_preferred_nid != nid) { > > + if (p->numa_preferred_nid != nid && > > + cpumask_weight(tsk_cpus_allowed(p)) > 1) { > > We have p->nr_cpus_allowed for that. > /me slaps self That's a bit easier to calculate, thanks. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org