From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx147.postini.com [74.125.245.147]) by kanga.kvack.org (Postfix) with SMTP id A08756B0034 for ; Sun, 7 Jul 2013 20:16:56 -0400 (EDT) Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 8 Jul 2013 10:04:56 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 405BC3578051 for ; Mon, 8 Jul 2013 10:16:49 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6801i5N721392 for ; Mon, 8 Jul 2013 10:01:45 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r680Gl6X013068 for ; Mon, 8 Jul 2013 10:16:48 +1000 Date: Mon, 8 Jul 2013 08:16:45 +0800 From: Wanpeng Li Subject: Re: [PATCH 2/3] mm/slab: Sharing s_next and s_stop between slab and slub Message-ID: <20130708001644.GA18895@hacker.(null)> Reply-To: Wanpeng Li References: <1372069394-26167-1-git-send-email-liwanp@linux.vnet.ibm.com> <1372069394-26167-2-git-send-email-liwanp@linux.vnet.ibm.com> <0000013f9aeb70c6-f6dad22c-bb88-4313-8602-538a3f5cedf5-000000@email.amazonses.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Christoph Lameter , Matt Mackall , Glauber Costa , Andrew Morton , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org --jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jul 07, 2013 at 07:41:54PM +0300, Pekka Enberg wrote: >On Mon, Jul 1, 2013 at 6:48 PM, Christoph Lameter wrote: >> On Mon, 24 Jun 2013, David Rientjes wrote: >> >>> On Mon, 24 Jun 2013, Wanpeng Li wrote: >>> >>> > This patch shares s_next and s_stop between slab and slub. >>> > >>> >>> Just about the entire kernel includes slab.h, so I think you'll need to >>> give these slab-specific names instead of exporting "s_next" and "s_stop" >>> to everybody. >> >> He put the export into mm/slab.h. The headerfile is only included by >> mm/sl?b.c . > >But he then went on to add globally visible symbols "s_next" and >"s_stop" which is bad... > >Please send me an incremental patch on top of slab/next to fix this >up. Otherwise I'll revert it before sending a pull request to Linus. > > Pekka Hi Pekka, I attach the incremental patch in attachment. ;-) Regards, Wanpeng Li --jRHKVT23PllUwdXP Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-slab.patch" --jRHKVT23PllUwdXP--