From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Nadia Yvette Chambers <nyc@holomorphy.com>
Subject: [PATCH 3/5] hugetlbfs: remove cancel_dirty_page() from truncate_huge_page()
Date: Mon, 08 Jul 2013 13:52:10 +0400 [thread overview]
Message-ID: <20130708095210.13810.6106.stgit@zurg> (raw)
In-Reply-To: <20130708095202.13810.11659.stgit@zurg>
There is no backend and writeback, dirty pages accounting is disabled.
ClearPageDirty() more suits for this place.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Nadia Yvette Chambers <nyc@holomorphy.com>
---
fs/hugetlbfs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index a3f868a..548badf 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -323,7 +323,7 @@ static int hugetlbfs_write_end(struct file *file, struct address_space *mapping,
static void truncate_huge_page(struct page *page)
{
- cancel_dirty_page(page, /* No IO accounting for huge pages? */0);
+ ClearPageDirty(page);
ClearPageUptodate(page);
delete_from_page_cache(page);
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-08 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 9:52 [PATCH 1/5] mm: remove redundant dirty pages check from __delete_from_page_cache() Konstantin Khlebnikov
2013-07-08 9:52 ` [PATCH 2/5] nfs: remove redundant cancel_dirty_page() from nfs_wb_page_cancel() Konstantin Khlebnikov
2013-07-08 9:52 ` Konstantin Khlebnikov [this message]
2013-07-08 9:52 ` [PATCH 4/5] page_writeback: get rid of account_size argument in cancel_dirty_page() Konstantin Khlebnikov
2013-07-08 9:52 ` [PATCH 5/5] page_writeback: put account_page_redirty() after set_page_dirty() Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130708095210.13810.6106.stgit@zurg \
--to=khlebnikov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nyc@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).