From: Tejun Heo <tj@kernel.org>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Vivek Goyal <vgoyal@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.cz>,
cgroups@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Sha Zhengju <handai.szj@gmail.com>,
devel@openvz.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH RFC] fsio: filesystem io accounting cgroup
Date: Tue, 9 Jul 2013 06:45:58 -0700 [thread overview]
Message-ID: <20130709134558.GD2478@htj.dyndns.org> (raw)
In-Reply-To: <51DC136E.6020901@openvz.org>
On Tue, Jul 09, 2013 at 05:43:10PM +0400, Konstantin Khlebnikov wrote:
> My concept it cgroup which would control io operation on vfs layer
> for all filesystems. It will account and manage IO operations. I've
> found really lightweight technique for accounting and throttling
> which don't introduce new locks or priority inversions (which is
> major problem in all existing throttlers, including cpu cgroup rate
> limiter) So, I've tried to keep code smaller, cleaner and saner as
> possible while you guys are trying to push me into the block layer
> =)
You're trying to implement QoS in the place where you don't have
control of the queue itself. You aren't even managing the right type
of resource for disks which is time slice rather than iops or
bandwidth and by the time you implemented proper hierarchy support and
proportional control, yours isn't gonna be that simple either. The
root problem is bdi failing to propagate pressure from the actual
queue upwards. Fix that.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-09 13:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 10:01 [PATCH RFC] fsio: filesystem io accounting cgroup Konstantin Khlebnikov
2013-07-08 17:00 ` Tejun Heo
2013-07-08 17:52 ` Vivek Goyal
2013-07-08 17:56 ` Tejun Heo
2013-07-09 8:28 ` Konstantin Khlebnikov
2013-07-09 12:57 ` Tejun Heo
2013-07-09 13:15 ` Konstantin Khlebnikov
2013-07-09 13:16 ` Tejun Heo
2013-07-09 13:16 ` Tejun Heo
2013-07-09 13:43 ` Konstantin Khlebnikov
2013-07-09 13:45 ` Tejun Heo [this message]
2013-07-09 14:18 ` Vivek Goyal
2013-07-09 14:29 ` Tejun Heo
2013-07-09 14:54 ` Vivek Goyal
2013-07-09 15:08 ` Tejun Heo
[not found] ` <20130710030955.GA3569@redhat.com>
2013-07-10 3:50 ` Tejun Heo
2013-07-09 14:35 ` Konstantin Khlebnikov
2013-07-09 14:42 ` Tejun Heo
2013-07-09 15:06 ` Vivek Goyal
2013-07-09 17:42 ` Konstantin Khlebnikov
2013-07-09 18:35 ` Vivek Goyal
2013-07-09 20:54 ` Konstantin Khlebnikov
2013-07-08 18:11 ` Vivek Goyal
2013-07-09 15:39 ` Theodore Ts'o
2013-07-09 17:12 ` Konstantin Khlebnikov
-- strict thread matches above, loose matches on Subject: below --
2013-07-08 9:59 Konstantin Khlebnikov
2013-07-10 4:43 ` Sha Zhengju
2013-07-10 6:03 ` Konstantin Khlebnikov
2013-07-10 8:37 ` Sha Zhengju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709134558.GD2478@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=devel@openvz.org \
--cc=handai.szj@gmail.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).