From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx166.postini.com [74.125.245.166]) by kanga.kvack.org (Postfix) with SMTP id DBA486B0034 for ; Wed, 10 Jul 2013 06:43:02 -0400 (EDT) Date: Wed, 10 Jul 2013 13:42:53 +0300 From: Gleb Natapov Subject: Re: [PATCH 3/4] PF: Provide additional direct page notification Message-ID: <20130710104253.GQ24941@redhat.com> References: <1373378207-10451-1-git-send-email-dingel@linux.vnet.ibm.com> <1373378207-10451-4-git-send-email-dingel@linux.vnet.ibm.com> <51DC33E7.1030404@de.ibm.com> <282EB214-206B-4A04-9830-D97679C9F4EC@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <282EB214-206B-4A04-9830-D97679C9F4EC@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Alexander Graf Cc: Christian Borntraeger , Dominik Dingel , Paolo Bonzini , Heiko Carstens , Martin Schwidefsky , Cornelia Huck , Xiantao Zhang , Christoffer Dall , Marc Zyngier , Ralf Baechle , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Wed, Jul 10, 2013 at 12:39:01PM +0200, Alexander Graf wrote: > > On 09.07.2013, at 18:01, Christian Borntraeger wrote: > > > On 09/07/13 15:56, Dominik Dingel wrote: > >> By setting a Kconfig option, the architecture can control when > >> guest notifications will be presented by the apf backend. > >> So there is the default batch mechanism, working as before, where the vcpu thread > >> should pull in this information. On the other hand there is now the direct > >> mechanism, this will directly push the information to the guest. > >> > >> Still the vcpu thread should call check_completion to cleanup leftovers, > >> that leaves most of the common code untouched. > >> > >> Signed-off-by: Dominik Dingel > > > > Acked-by: Christian Borntraeger > > for the "why". We want to use the existing architectured interface. > > Shouldn't this be a runtime option? > Why? What is the advantage of using sync delivery when HW can do it async? -- Gleb. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org