From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Pekka Enberg <penberg@kernel.org>,
Colin Cross <ccross@android.com>,
linux-kernel@vger.kernel.org,
Kyungmin Park <kmpark@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
John Stultz <john.stultz@linaro.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Dave Hansen <dave.hansen@intel.com>,
Rob Landley <rob@landley.net>,
Andrew Morton <akpm@linux-foundation.org>,
Cyrill Gorcunov <gorcunov@openvz.org>,
David Rientjes <rientjes@google.com>,
Davidlohr Bueso <dave@gnu.org>, Kees Cook <keescook@chromium.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Hugh Dickins <hughd@google.com>, Mel Gorman <mgorman@suse.de>,
Michel Lespinasse <walken@google.com>,
Rik van Riel <riel@redhat.com>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Arnd Bergmann <arnd@arndb.de>, Dave Jones <davej@redhat.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Oleg Nesterov <oleg@redhat.com>, Shaohua Li <shli@fusionio.com>,
Sasha Levin <sasha.levin@oracle.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-doc@vger.kernel.org, linux-mm@kvack.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/2] mm: add a field to store names for private anonymous memory
Date: Fri, 12 Jul 2013 11:15:06 +0200 [thread overview]
Message-ID: <20130712091506.GA5315@gmail.com> (raw)
In-Reply-To: <20130712090046.GP25631@dyad.programming.kicks-ass.net>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Jul 12, 2013 at 10:44:06AM +0200, Ingo Molnar wrote:
> > It makes tons of sense.
> >
> > Just like we have a task's cmd-name it makes a lot of sense to name
> > objects in a human readable fashion, to help debugging, instrumentation,
> > performance analysis, etc.
> >
> > Yes, in theory user-space could do all that. That's not the point: the
> > point is to make it fast, easy enough and to have a central version (the
> > kernel).
> >
> > Doing it via temporary files has various disadvantages:
>
> We need those files anyway.. The current proposal is that the entire VMA
> has a single userspace pointer in it. Or rather a 64bit value.
Yes but accessible via /proc/<PID>/mem or so?
> > I guess the real question is not whether it's useful, I think it
> > clearly is. The question should be: are there real downsides? Does the
> > addition to the anon mmap field blow up the size of vma_struct by a
> > pointer, or is there still space?
>
> I don't see how the single u64 is useful at all for perf; you can have
> at most one u64 per page; that's not nearly enough to put symbol
> information in. Therefore we still require external files.
I was thinking about it in the context of its original purpose: naming
heap areas, which are pretty anonymous right now - /proc/*/maps is full
of mystery ranges today.
It's indeed not good enough for finer grained structure.
Thanks,
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-12 9:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 2:34 [PATCH 1/2] mm: rearrange madvise code to allow for reuse Colin Cross
2013-07-12 2:34 ` [PATCH 2/2] mm: add a field to store names for private anonymous memory Colin Cross
2013-07-12 5:39 ` Pekka Enberg
2013-07-12 8:13 ` Peter Zijlstra
2013-07-12 8:17 ` Peter Zijlstra
2013-07-12 8:44 ` Ingo Molnar
2013-07-12 8:55 ` Pekka Enberg
2013-07-12 9:00 ` Peter Zijlstra
2013-07-12 9:15 ` Ingo Molnar [this message]
2013-07-12 9:27 ` Peter Zijlstra
2013-07-12 9:40 ` Ingo Molnar
2013-07-12 9:49 ` Peter Zijlstra
2013-07-12 10:01 ` Ingo Molnar
2013-07-12 20:51 ` Colin Cross
2013-09-26 1:24 ` Colin Cross
2013-07-12 8:21 ` Pekka Enberg
2013-07-12 8:55 ` Peter Zijlstra
2013-07-12 9:04 ` Pekka Enberg
2013-07-12 9:14 ` Peter Zijlstra
2013-07-12 9:28 ` Ingo Molnar
2013-07-12 9:26 ` Ingo Molnar
2013-07-12 9:38 ` Pekka Enberg
2013-07-12 9:45 ` Ingo Molnar
2013-07-12 10:09 ` Peter Zijlstra
2013-07-12 5:43 ` Pekka Enberg
2013-07-12 6:18 ` Colin Cross
2013-07-12 7:03 ` Pekka Enberg
2013-07-12 6:36 ` Dave Hansen
2013-07-12 6:42 ` Colin Cross
2013-07-14 14:11 ` Oleg Nesterov
2013-07-14 19:27 ` Colin Cross
2013-07-14 14:17 ` Oleg Nesterov
2013-07-14 19:34 ` Colin Cross
-- strict thread matches above, loose matches on Subject: below --
2013-10-15 1:31 [PATCHv3 1/2] mm: rearrange madvise code to allow for reuse Colin Cross
2013-10-15 1:31 ` [PATCH 2/2] mm: add a field to store names for private anonymous memory Colin Cross
2013-10-15 21:21 ` Andrew Morton
2013-10-15 21:32 ` Dave Hansen
2013-10-15 21:47 ` Colin Cross
2013-10-16 0:33 ` Minchan Kim
2013-10-16 20:00 ` Colin Cross
2013-10-16 20:34 ` Dave Hansen
2013-10-16 20:41 ` Colin Cross
2013-10-17 2:47 ` Minchan Kim
2013-10-30 21:15 ` Colin Cross
2013-11-01 1:30 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130712091506.GA5315@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=ccross@android.com \
--cc=dave.hansen@intel.com \
--cc=dave@gnu.org \
--cc=davej@redhat.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=gorcunov@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=khlebnikov@openvz.org \
--cc=kmpark@infradead.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=rob@landley.net \
--cc=sasha.levin@oracle.com \
--cc=shli@fusionio.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).