From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx110.postini.com [74.125.245.110]) by kanga.kvack.org (Postfix) with SMTP id 721966B0031 for ; Tue, 23 Jul 2013 20:57:26 -0400 (EDT) Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Jul 2013 10:41:39 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id A3AC33578050 for ; Wed, 24 Jul 2013 10:57:18 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6O0v7Zu10682746 for ; Wed, 24 Jul 2013 10:57:08 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6O0vGLn024298 for ; Wed, 24 Jul 2013 10:57:17 +1000 Date: Wed, 24 Jul 2013 08:57:15 +0800 From: Wanpeng Li Subject: Re: [PATCH v2 01/10] mm, hugetlb: move up the code which check availability of free huge page Message-ID: <20130724005715.GA17662@hacker.(null)> Reply-To: Wanpeng Li References: <1374482191-3500-1-git-send-email-iamjoonsoo.kim@lge.com> <1374482191-3500-2-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374482191-3500-2-git-send-email-iamjoonsoo.kim@lge.com> Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Andrew Morton , Rik van Riel , Mel Gorman , Michal Hocko , "Aneesh Kumar K.V" , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim On Mon, Jul 22, 2013 at 05:36:22PM +0900, Joonsoo Kim wrote: >In this time we are holding a hugetlb_lock, so hstate values can't >be changed. If we don't have any usable free huge page in this time, >we don't need to proceede the processing. So move this code up. > >Signed-off-by: Joonsoo Kim > Reviewed-by: Wanpeng Li >diff --git a/mm/hugetlb.c b/mm/hugetlb.c >index e2bfbf7..fc4988c 100644 >--- a/mm/hugetlb.c >+++ b/mm/hugetlb.c >@@ -539,10 +539,6 @@ static struct page *dequeue_huge_page_vma(struct hstate *h, > struct zoneref *z; > unsigned int cpuset_mems_cookie; > >-retry_cpuset: >- cpuset_mems_cookie = get_mems_allowed(); >- zonelist = huge_zonelist(vma, address, >- htlb_alloc_mask, &mpol, &nodemask); > /* > * A child process with MAP_PRIVATE mappings created by their parent > * have no page reserves. This check ensures that reservations are >@@ -556,6 +552,11 @@ retry_cpuset: > if (avoid_reserve && h->free_huge_pages - h->resv_huge_pages == 0) > goto err; > >+retry_cpuset: >+ cpuset_mems_cookie = get_mems_allowed(); >+ zonelist = huge_zonelist(vma, address, >+ htlb_alloc_mask, &mpol, &nodemask); >+ > for_each_zone_zonelist_nodemask(zone, z, zonelist, > MAX_NR_ZONES - 1, nodemask) { > if (cpuset_zone_allowed_softwall(zone, htlb_alloc_mask)) { >@@ -574,7 +575,6 @@ retry_cpuset: > return page; > > err: >- mpol_cond_put(mpol); > return NULL; > } > >-- >1.7.9.5 > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org