From: Minchan Kim <minchan@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Paul Szabo <psz@maths.usyd.edu.au>,
Rik van Riel <riel@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] Revert "page-writeback.c: subtract min_free_kbytes from dirtyable memory"
Date: Fri, 26 Jul 2013 08:30:13 +0900 [thread overview]
Message-ID: <20130725233013.GC27252@bbox> (raw)
In-Reply-To: <1374793134-16678-1-git-send-email-hannes@cmpxchg.org>
On Thu, Jul 25, 2013 at 06:58:54PM -0400, Johannes Weiner wrote:
> This reverts commit 75f7ad8e043d9383337d917584297f7737154bbf. It was
> the result of a problem observed with a 3.2 kernel and merged in 3.9,
> while the issue had been resolved upstream in 3.3 (ab8fabd mm: exclude
> reserved pages from dirtyable memory).
>
> The "reserved pages" are a superset of min_free_kbytes, thus this
> change is redundant and confusing. Revert it.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Absolutely true and I pointed it out at that time but ignored and merged. :(
http://lists.debian.org/debian-kernel/2013/01/msg00538.html
Even, not Cced so I couldn't notice it until you send out this patch.
Acked-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-07-25 23:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 22:58 [patch] Revert "page-writeback.c: subtract min_free_kbytes from dirtyable memory" Johannes Weiner
2013-07-25 23:30 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725233013.GC27252@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=psz@maths.usyd.edu.au \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).