[patch] Revert "page-writeback.c: subtract min_free_kbytes from dirtyable memory"

[patch] Revert "page-writeback.c: subtract min_free_kbytes from dirtyable memory"

[Johannes Weiner]

This reverts commit 75f7ad8e043d9383337d917584297f7737154bbf.  It was
the result of a problem observed with a 3.2 kernel and merged in 3.9,
while the issue had been resolved upstream in 3.3 (ab8fabd mm: exclude
reserved pages from dirtyable memory).

The "reserved pages" are a superset of min_free_kbytes, thus this
change is redundant and confusing.  Revert it.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
 mm/page-writeback.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 3f0c895..d374b29 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -241,9 +241,6 @@ static unsigned long global_dirtyable_memory(void)
 	if (!vm_highmem_is_dirtyable)
 		x -= highmem_dirtyable_memory(x);
 
-	/* Subtract min_free_kbytes */
-	x -= min_t(unsigned long, x, min_free_kbytes >> (PAGE_SHIFT - 10));
-
 	return x + 1;	/* Ensure that we never return 0 */
 }
 
-- 
1.8.3.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [patch] Revert "page-writeback.c: subtract min_free_kbytes from dirtyable memory"

[Minchan Kim]

On Thu, Jul 25, 2013 at 06:58:54PM -0400, Johannes Weiner wrote:
> This reverts commit 75f7ad8e043d9383337d917584297f7737154bbf.  It was
> the result of a problem observed with a 3.2 kernel and merged in 3.9,
> while the issue had been resolved upstream in 3.3 (ab8fabd mm: exclude
> reserved pages from dirtyable memory).
> 
> The "reserved pages" are a superset of min_free_kbytes, thus this
> change is redundant and confusing.  Revert it.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Absolutely true and I pointed it out at that time but ignored and merged. :(
http://lists.debian.org/debian-kernel/2013/01/msg00538.html
Even, not Cced so I couldn't notice it until you send out this patch.

Acked-by: Minchan Kim <minchan@kernel.org>

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>