From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx167.postini.com [74.125.245.167]) by kanga.kvack.org (Postfix) with SMTP id 7E39A6B0033 for ; Mon, 29 Jul 2013 11:02:14 -0400 (EDT) Received: by mail-lb0-f170.google.com with SMTP id r10so40516lbi.29 for ; Mon, 29 Jul 2013 08:02:12 -0700 (PDT) Date: Mon, 29 Jul 2013 19:02:09 +0400 From: Cyrill Gorcunov Subject: Re: [PATCH] mm: Save soft-dirty bits on file pages Message-ID: <20130729150209.GO2524@moon> References: <20130726201807.GJ8661@moon> <51F67777.6060609@parallels.com> <20130729141417.GM2524@moon> <878v0ps98x.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878v0ps98x.fsf@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Aneesh Kumar K.V" Cc: Pavel Emelyanov , Linux MM , LKML , Andy Lutomirski , Andrew Morton , Matt Mackall , Xiao Guangrong , Marcelo Tosatti , KOSAKI Motohiro , Stephen Rothwell On Mon, Jul 29, 2013 at 08:28:54PM +0530, Aneesh Kumar K.V wrote: > > > > If only I'm not missing something obvious, this code compiles not only on x86, > > CONFIG_MEM_SOFT_DIRTY depends on x86 (otherwise I'll have to implement > > pte_soft_dirty for all archs). > > why not > > #ifndef pte_soft_dirty > #define pte_soft_dirty(pte) 0 > #endif > > and on x86 > #define pte_soft_dirty pte_soft_dirty Yeah, either this way, either to use asm-generic (later I think more preferred), thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org