From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizefan@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Glauber Costa <glommer@parallels.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH v3 1/8] cgroup: convert cgroup_ida to cgroup_idr
Date: Mon, 29 Jul 2013 14:28:35 -0400 [thread overview]
Message-ID: <20130729182835.GD26076@mtj.dyndns.org> (raw)
In-Reply-To: <51F614C4.7060602@huawei.com>
Hello,
On Mon, Jul 29, 2013 at 03:07:48PM +0800, Li Zefan wrote:
> @@ -4590,6 +4599,9 @@ static void cgroup_offline_fn(struct work_struct *work)
> /* delete this cgroup from parent->children */
> list_del_rcu(&cgrp->sibling);
>
> + if (cgrp->id)
> + idr_remove(&cgrp->root->cgroup_idr, cgrp->id);
> +
Yeap, if we're gonna allow lookups, removal should happen here but can
we please add short comment explaining why that is? Also, do we want
to clear cgrp->id?
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-29 18:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 7:07 [PATCH v3 0/8] memcg, cgroup: kill css_id Li Zefan
2013-07-29 7:07 ` [PATCH v3 1/8] cgroup: convert cgroup_ida to cgroup_idr Li Zefan
2013-07-29 18:28 ` Tejun Heo [this message]
2013-07-30 1:10 ` Li Zefan
2013-07-30 14:21 ` Tejun Heo
2013-07-29 7:08 ` [PATCH v3 2/8] cgroup: document how cgroup IDs are assigned Li Zefan
2013-07-29 18:26 ` Tejun Heo
2013-07-30 1:08 ` Li Zefan
2013-07-30 14:22 ` Tejun Heo
2013-07-29 7:08 ` [PATCH v3 3/8] cgroup: implement cgroup_from_id() Li Zefan
2013-07-29 18:31 ` Tejun Heo
2013-07-29 7:08 ` [PATCH v3 4/8] memcg: convert to use cgroup_is_descendant() Li Zefan
2013-07-29 7:08 ` [PATCH v3 5/8] memcg: convert to use cgroup id Li Zefan
2013-07-29 7:09 ` [PATCH v3 6/8] memcg: fail to create cgroup if the cgroup id is too big Li Zefan
2013-07-29 7:09 ` [PATCH v3 7/8] memcg: stop using css id Li Zefan
2013-07-29 7:10 ` [PATCH v3 8/8] cgroup: kill css_id Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729182835.GD26076@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).