From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx145.postini.com [74.125.245.145]) by kanga.kvack.org (Postfix) with SMTP id AD9856B0031 for ; Wed, 31 Jul 2013 00:41:03 -0400 (EDT) Date: Wed, 31 Jul 2013 13:41:01 +0900 From: Joonsoo Kim Subject: Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages Message-ID: <20130731044101.GE2548@lge.com> References: <1375075929-6119-1-git-send-email-iamjoonsoo.kim@lge.com> <1375075929-6119-2-git-send-email-iamjoonsoo.kim@lge.com> <20130731022751.GA2548@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: Andrew Morton , Rik van Riel , Mel Gorman , Michal Hocko , "Aneesh Kumar K.V" , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wanpeng Li , Naoya Horiguchi On Wed, Jul 31, 2013 at 10:49:24AM +0800, Hillf Danton wrote: > On Wed, Jul 31, 2013 at 10:27 AM, Joonsoo Kim wrote: > > On Mon, Jul 29, 2013 at 03:24:46PM +0800, Hillf Danton wrote: > >> On Mon, Jul 29, 2013 at 1:31 PM, Joonsoo Kim wrote: > >> > alloc_huge_page_node() use dequeue_huge_page_node() without > >> > any validation check, so it can steal reserved page unconditionally. > >> > >> Well, why is it illegal to use reserved page here? > > > > If we use reserved page here, other processes which are promised to use > > enough hugepages cannot get enough hugepages and can die. This is > > unexpected result to them. > > > But, how do you determine that a huge page is requested by a process > that is not allowed to use reserved pages? Reserved page is just one for each address or file offset. If we need to move this page, this means that it already use it's own reserved page, this page is it. So we should not use other reserved page for moving this page. Thanks. > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org