* [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages"
@ 2013-07-31 8:50 Joonyoung Shim
2013-07-31 11:17 ` Bartlomiej Zolnierkiewicz
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Joonyoung Shim @ 2013-07-31 8:50 UTC (permalink / raw)
To: linux-mm; +Cc: akpm, linux-kernel, liuj97, kosaki.motohiro
This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
Fixed to adjust totalhigh_pages when hot-removing memory by commit
3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
duplicated decreasing of totalhigh_pages.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
The commit cea27eb2a202959783f81254c48c250ddd80e129 is only for stable,
is it right?
mm/page_alloc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b100255..2b28216 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6274,10 +6274,6 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
list_del(&page->lru);
rmv_page_order(page);
zone->free_area[order].nr_free--;
-#ifdef CONFIG_HIGHMEM
- if (PageHighMem(page))
- totalhigh_pages -= 1 << order;
-#endif
for (i = 0; i < (1 << order); i++)
SetPageReserved((page+i));
pfn += (1 << order);
--
1.8.1.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages"
2013-07-31 8:50 [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages" Joonyoung Shim
@ 2013-07-31 11:17 ` Bartlomiej Zolnierkiewicz
2013-07-31 11:48 ` Bartlomiej Zolnierkiewicz
2013-08-04 7:49 ` Wanpeng Li
2013-08-04 7:49 ` Wanpeng Li
2 siblings, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-07-31 11:17 UTC (permalink / raw)
To: Joonyoung Shim; +Cc: linux-mm, akpm, linux-kernel, liuj97, kosaki.motohiro
Hi,
On Wednesday, July 31, 2013 05:50:02 PM Joonyoung Shim wrote:
> This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
Could you please also include commit descriptions, i.e.
commit cea27eb2a202959783f81254c48c250ddd80e129 ("mm/memory-hotplug: fix
lowmem count overflow when offline pages")?
> Fixed to adjust totalhigh_pages when hot-removing memory by commit
> 3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
> duplicated decreasing of totalhigh_pages.
Could you please describe it a bit more (because it is non-obvious) how
the commit cea27eb effectively does the same totalhigh_pages adjustment
that is present in the commit 3dcc057?
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> The commit cea27eb2a202959783f81254c48c250ddd80e129 is only for stable,
> is it right?
It is in Linus' tree now but you're probably right that it should be
limited to stable tree.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> mm/page_alloc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index b100255..2b28216 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6274,10 +6274,6 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
> list_del(&page->lru);
> rmv_page_order(page);
> zone->free_area[order].nr_free--;
> -#ifdef CONFIG_HIGHMEM
> - if (PageHighMem(page))
> - totalhigh_pages -= 1 << order;
> -#endif
> for (i = 0; i < (1 << order); i++)
> SetPageReserved((page+i));
> pfn += (1 << order);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages"
2013-07-31 11:17 ` Bartlomiej Zolnierkiewicz
@ 2013-07-31 11:48 ` Bartlomiej Zolnierkiewicz
2013-08-09 0:58 ` Joonyoung Shim
0 siblings, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-07-31 11:48 UTC (permalink / raw)
To: Joonyoung Shim
Cc: linux-mm, akpm, linux-kernel, liuj97, kosaki.motohiro, Wanpeng Li
On Wednesday, July 31, 2013 01:17:46 PM Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Wednesday, July 31, 2013 05:50:02 PM Joonyoung Shim wrote:
> > This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
>
> Could you please also include commit descriptions, i.e.
> commit cea27eb2a202959783f81254c48c250ddd80e129 ("mm/memory-hotplug: fix
> lowmem count overflow when offline pages")?
>
> > Fixed to adjust totalhigh_pages when hot-removing memory by commit
> > 3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
> > duplicated decreasing of totalhigh_pages.
>
> Could you please describe it a bit more (because it is non-obvious) how
> the commit cea27eb effectively does the same totalhigh_pages adjustment
> that is present in the commit 3dcc057?
Err, the other way around. How the commit 3dcc057 ("mm: correctly update
zone->managed_pages") does what cea27eb ("mm/memory-hotplug: fix lowmem
count overflow when offline pages") did.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> > Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> > ---
> > The commit cea27eb2a202959783f81254c48c250ddd80e129 is only for stable,
> > is it right?
>
> It is in Linus' tree now but you're probably right that it should be
> limited to stable tree.
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
> > mm/page_alloc.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index b100255..2b28216 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -6274,10 +6274,6 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
> > list_del(&page->lru);
> > rmv_page_order(page);
> > zone->free_area[order].nr_free--;
> > -#ifdef CONFIG_HIGHMEM
> > - if (PageHighMem(page))
> > - totalhigh_pages -= 1 << order;
> > -#endif
> > for (i = 0; i < (1 << order); i++)
> > SetPageReserved((page+i));
> > pfn += (1 << order);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages"
2013-07-31 8:50 [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages" Joonyoung Shim
2013-07-31 11:17 ` Bartlomiej Zolnierkiewicz
@ 2013-08-04 7:49 ` Wanpeng Li
2013-08-04 7:49 ` Wanpeng Li
2 siblings, 0 replies; 6+ messages in thread
From: Wanpeng Li @ 2013-08-04 7:49 UTC (permalink / raw)
To: Joonyoung Shim; +Cc: linux-mm, akpm, linux-kernel, liuj97, kosaki.motohiro
On Wed, Jul 31, 2013 at 05:50:02PM +0900, Joonyoung Shim wrote:
>This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
>
>Fixed to adjust totalhigh_pages when hot-removing memory by commit
>3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
>duplicated decreasing of totalhigh_pages.
>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>---
>The commit cea27eb2a202959783f81254c48c250ddd80e129 is only for stable,
>is it right?
>
> mm/page_alloc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>index b100255..2b28216 100644
>--- a/mm/page_alloc.c
>+++ b/mm/page_alloc.c
>@@ -6274,10 +6274,6 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
> list_del(&page->lru);
> rmv_page_order(page);
> zone->free_area[order].nr_free--;
>-#ifdef CONFIG_HIGHMEM
>- if (PageHighMem(page))
>- totalhigh_pages -= 1 << order;
>-#endif
> for (i = 0; i < (1 << order); i++)
> SetPageReserved((page+i));
> pfn += (1 << order);
>--
>1.8.1.2
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages"
2013-07-31 8:50 [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages" Joonyoung Shim
2013-07-31 11:17 ` Bartlomiej Zolnierkiewicz
2013-08-04 7:49 ` Wanpeng Li
@ 2013-08-04 7:49 ` Wanpeng Li
2 siblings, 0 replies; 6+ messages in thread
From: Wanpeng Li @ 2013-08-04 7:49 UTC (permalink / raw)
To: Joonyoung Shim; +Cc: linux-mm, akpm, linux-kernel, liuj97, kosaki.motohiro
On Wed, Jul 31, 2013 at 05:50:02PM +0900, Joonyoung Shim wrote:
>This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
>
>Fixed to adjust totalhigh_pages when hot-removing memory by commit
>3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
>duplicated decreasing of totalhigh_pages.
>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>---
>The commit cea27eb2a202959783f81254c48c250ddd80e129 is only for stable,
>is it right?
>
> mm/page_alloc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>index b100255..2b28216 100644
>--- a/mm/page_alloc.c
>+++ b/mm/page_alloc.c
>@@ -6274,10 +6274,6 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
> list_del(&page->lru);
> rmv_page_order(page);
> zone->free_area[order].nr_free--;
>-#ifdef CONFIG_HIGHMEM
>- if (PageHighMem(page))
>- totalhigh_pages -= 1 << order;
>-#endif
> for (i = 0; i < (1 << order); i++)
> SetPageReserved((page+i));
> pfn += (1 << order);
>--
>1.8.1.2
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages"
2013-07-31 11:48 ` Bartlomiej Zolnierkiewicz
@ 2013-08-09 0:58 ` Joonyoung Shim
0 siblings, 0 replies; 6+ messages in thread
From: Joonyoung Shim @ 2013-08-09 0:58 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-mm, akpm, linux-kernel, liuj97, kosaki.motohiro
On 07/31/2013 08:48 PM, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday, July 31, 2013 01:17:46 PM Bartlomiej Zolnierkiewicz wrote:
>> Hi,
>>
>> On Wednesday, July 31, 2013 05:50:02 PM Joonyoung Shim wrote:
>>> This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
>> Could you please also include commit descriptions, i.e.
>> commit cea27eb2a202959783f81254c48c250ddd80e129 ("mm/memory-hotplug: fix
>> lowmem count overflow when offline pages")?
>>
>>> Fixed to adjust totalhigh_pages when hot-removing memory by commit
>>> 3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
>>> duplicated decreasing of totalhigh_pages.
>> Could you please describe it a bit more (because it is non-obvious) how
>> the commit cea27eb effectively does the same totalhigh_pages adjustment
>> that is present in the commit 3dcc057?
> Err, the other way around. How the commit 3dcc057 ("mm: correctly update
> zone->managed_pages") does what cea27eb ("mm/memory-hotplug: fix lowmem
> count overflow when offline pages") did.
>
OK, i updated to patch v2.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-09 0:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-31 8:50 [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages" Joonyoung Shim
2013-07-31 11:17 ` Bartlomiej Zolnierkiewicz
2013-07-31 11:48 ` Bartlomiej Zolnierkiewicz
2013-08-09 0:58 ` Joonyoung Shim
2013-08-04 7:49 ` Wanpeng Li
2013-08-04 7:49 ` Wanpeng Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).