From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Minchan Kim <minchan@kernel.org>, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>,
Michel Lespinasse <walken@google.com>
Subject: Re: [PATCH 1/4] mm, rmap: do easy-job first in anon_vma_fork
Date: Wed, 7 Aug 2013 16:16:24 +0900 [thread overview]
Message-ID: <20130807071624.GA32449@lge.com> (raw)
In-Reply-To: <20130806125854.GG1845@cmpxchg.org>
Hello, Johannes.
On Tue, Aug 06, 2013 at 08:58:54AM -0400, Johannes Weiner wrote:
> > if (anon_vma_clone(vma, pvma))
> > - return -ENOMEM;
> > -
> > - /* Then add our own anon_vma. */
> > - anon_vma = anon_vma_alloc();
> > - if (!anon_vma)
> > - goto out_error;
> > - avc = anon_vma_chain_alloc(GFP_KERNEL);
> > - if (!avc)
> > goto out_error_free_anon_vma;
>
> Which heavy work? anon_vma_clone() is anon_vma_chain_alloc() in a
> loop.
>
> Optimizing error paths only makes sense if they are common and you
> actually could save something by reordering. This matches neither.
Yes, you are right. I drop this one.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-08-07 7:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 8:43 [PATCH 1/4] mm, rmap: do easy-job first in anon_vma_fork Joonsoo Kim
2013-08-06 8:43 ` [PATCH 2/4] mm, rmap: allocate anon_vma_chain before starting to link anon_vma_chain Joonsoo Kim
2013-08-07 6:08 ` Johannes Weiner
2013-08-07 7:17 ` Joonsoo Kim
2013-08-06 8:43 ` [PATCH 3/4] mm, rmap: minimize lock hold when unlink_anon_vmas Joonsoo Kim
2013-08-07 6:11 ` Johannes Weiner
2013-08-07 7:18 ` Joonsoo Kim
2013-08-06 8:43 ` [PATCH 4/4] mm, page_alloc: optimize batch count in free_pcppages_bulk() Joonsoo Kim
2013-08-06 8:48 ` Joonsoo Kim
2013-08-06 12:58 ` [PATCH 1/4] mm, rmap: do easy-job first in anon_vma_fork Johannes Weiner
2013-08-07 7:16 ` Joonsoo Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807071624.GA32449@lge.com \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).