From: Mel Gorman <mgorman@suse.de>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@surriel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Zlatko Calusic <zcalusic@bitsync.net>,
Minchan Kim <minchan@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch v2 1/3] mm: vmscan: fix numa reclaim balance problem in kswapd
Date: Wed, 7 Aug 2013 15:15:55 +0100 [thread overview]
Message-ID: <20130807141555.GO2296@suse.de> (raw)
In-Reply-To: <1375457846-21521-2-git-send-email-hannes@cmpxchg.org>
On Fri, Aug 02, 2013 at 11:37:24AM -0400, Johannes Weiner wrote:
> When the page allocator fails to get a page from all zones in its
> given zonelist, it wakes up the per-node kswapds for all zones that
> are at their low watermark.
>
> However, with a system under load the free pages in a zone can
> fluctuate enough that the allocation fails but the kswapd wakeup is
> also skipped while the zone is still really close to the low
> watermark.
>
> When one node misses a wakeup like this, it won't be aged before all
> the other node's zones are down to their low watermarks again. And
> skipping a full aging cycle is an obvious fairness problem.
>
> Kswapd runs until the high watermarks are restored, so it should also
> be woken when the high watermarks are not met. This ages nodes more
> equally and creates a safety margin for the page counter fluctuation.
>
> By using zone_balanced(), it will now check, in addition to the
> watermark, if compaction requires more order-0 pages to create a
> higher order page.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> Reviewed-by: Rik van Riel <riel@redhat.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-07 14:16 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 15:37 [patch v2 0/3] mm: improve page aging fairness between zones/nodes Johannes Weiner
2013-08-02 15:37 ` [patch v2 1/3] mm: vmscan: fix numa reclaim balance problem in kswapd Johannes Weiner
2013-08-07 14:15 ` Mel Gorman [this message]
2013-08-02 15:37 ` [patch v2 2/3] mm: page_alloc: rearrange watermark checking in get_page_from_freelist Johannes Weiner
2013-08-07 14:20 ` Mel Gorman
2013-08-02 15:37 ` [patch v2 3/3] mm: page_alloc: fair zone allocator policy Johannes Weiner
2013-08-02 17:51 ` Rik van Riel
2013-08-05 1:15 ` Minchan Kim
2013-08-05 3:43 ` Johannes Weiner
2013-08-05 4:48 ` Minchan Kim
2013-08-05 5:01 ` Johannes Weiner
2013-08-05 10:34 ` Wanpeng Li
2013-08-05 10:34 ` Wanpeng Li
2013-08-05 11:34 ` Andrea Arcangeli
2013-08-05 13:11 ` Wanpeng Li
2013-08-05 13:11 ` Wanpeng Li
2013-08-07 14:58 ` Mel Gorman
2013-08-07 15:37 ` Johannes Weiner
2013-08-08 4:16 ` Johannes Weiner
2013-08-08 9:21 ` Mel Gorman
2013-08-09 18:45 ` Rik van Riel
2013-08-16 17:07 ` Kevin Hilman
2013-08-16 17:17 ` Kevin Hilman
2013-08-16 20:18 ` Johannes Weiner
2013-08-16 21:24 ` Stephen Warren
2013-08-16 21:52 ` Kevin Hilman
2013-08-19 0:48 ` Stephen Rothwell
2014-04-02 14:26 ` Thomas Schwinge
2014-04-24 13:37 ` radeon: screen garbled after page allocator change, was: " Johannes Weiner
2014-04-25 21:47 ` Jerome Glisse
2014-04-25 21:50 ` Jerome Glisse
2014-04-25 23:03 ` Jerome Glisse
2014-04-28 8:03 ` Thomas Schwinge
2014-04-28 9:09 ` Thomas Schwinge
2014-04-27 3:31 ` Jerome Glisse
2014-04-27 19:55 ` Jerome Glisse
2014-04-28 7:30 ` Christian König
2014-04-28 12:51 ` Deucher, Alexander
2014-04-28 12:52 ` Deucher, Alexander
2014-04-28 8:09 ` Thomas Schwinge
2014-06-16 7:11 ` Thomas Schwinge
2013-08-02 19:59 ` [patch v2 0/3] mm: improve page aging fairness between zones/nodes Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807141555.GO2296@suse.de \
--to=mgorman@suse.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=riel@surriel.com \
--cc=zcalusic@bitsync.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).