From: Benjamin LaHaise <bcrl@kvack.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Minchan Kim <minchan@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Mel Gorman <mgorman@suse.de>,
guz.fnst@cn.fujitsu.com, Dave Hansen <dave.hansen@intel.com>,
lliubbo@gmail.com, aquini@redhat.com,
Rik van Riel <riel@redhat.com>,
Tomasz Stanislawski <t.stanislaws@samsung.com>
Subject: Re: [RFC 0/3] Pin page control subsystem
Date: Tue, 13 Aug 2013 10:23:38 -0400 [thread overview]
Message-ID: <20130813142338.GD13330@kvack.org> (raw)
In-Reply-To: <1376387202.31048.2.camel@AMDC1943>
On Tue, Aug 13, 2013 at 11:46:42AM +0200, Krzysztof Kozlowski wrote:
> Hi Minchan,
>
> On wto, 2013-08-13 at 16:04 +0900, Minchan Kim wrote:
> > patch 2 introduce pinpage control
> > subsystem. So, subsystems want to control pinpage should implement own
> > pinpage_xxx functions because each subsystem would have other character
> > so what kinds of data structure for managing pinpage information depends
> > on them. Otherwise, they can use general functions defined in pinpage
> > subsystem. patch 3 hacks migration.c so that migration is
> > aware of pinpage now and migrate them with pinpage subsystem.
>
> I wonder why don't we use page->mapping and a_ops? Is there any
> disadvantage of such mapping/a_ops?
That's what the pending aio patches do, and I think this is a better
approach for those use-cases that the technique works for.
The biggest problem I see with the pinpage approach is that it's based on a
single page at a time. I'd venture a guess that many pinned pages are done
in groups of pages, not single ones.
-ben
> Best regards,
> Krzysztof
--
"Thought is the essence of where you are now."
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-13 14:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 7:04 [RFC 0/3] Pin page control subsystem Minchan Kim
2013-08-13 7:05 ` [RFC 1/3] mm: Introduce new page flag Minchan Kim
2013-08-13 7:05 ` [RFC 2/3] pinpage control subsystem Minchan Kim
2013-08-13 7:05 ` [RFC 3/3] mm: migrate pinned page Minchan Kim
2013-08-13 9:46 ` [RFC 0/3] Pin page control subsystem Krzysztof Kozlowski
2013-08-13 14:23 ` Benjamin LaHaise [this message]
2013-08-14 0:08 ` Minchan Kim
2013-08-13 23:54 ` Minchan Kim
2013-08-13 16:21 ` Christoph Lameter
2013-08-14 0:12 ` Minchan Kim
2013-08-14 16:36 ` Christoph Lameter
2013-08-14 16:47 ` Minchan Kim
2013-08-14 16:58 ` Christoph Lameter
2013-08-15 4:48 ` Minchan Kim
2013-08-15 15:18 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813142338.GD13330@kvack.org \
--to=bcrl@kvack.org \
--cc=aquini@redhat.com \
--cc=dave.hansen@intel.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=sjenning@linux.vnet.ibm.com \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).