From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
xemul@parallels.com, mpm@selenic.com,
xiaoguangrong@linux.vnet.ibm.com, mtosatti@redhat.com,
kosaki.motohiro@gmail.com, sfr@canb.auug.org.au,
peterz@infradead.org, aneesh.kumar@linux.vnet.ibm.com,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch 2/2] [PATCH] mm: Save soft-dirty bits on file pages
Date: Tue, 13 Aug 2013 19:37:03 +0400 [thread overview]
Message-ID: <20130813153703.GE2869@moon> (raw)
In-Reply-To: <520A4D5F.6020401@zytor.com>
On Tue, Aug 13, 2013 at 08:14:39AM -0700, H. Peter Anvin wrote:
> On 08/12/2013 10:02 PM, Cyrill Gorcunov wrote:
> >
> > There is a case when you don't need a mask completely. And because this
> > pte conversion is on hot path and time critical I kept generated code
> > as it was (even if that lead to slightly less clear source code).
> >
>
> Does it actually matter, generated-code-wise, or is the compiler smart
> enough to figure it out? The reason I'm asking is because it makes the
gcc-4.7.2 is smart enough to suppress useless masking (ie ((1u << 31) - 1))
completely but I don't know if this can be assumed for all gcc series.
> code much harder to follow.
I see. OK, I'll try to prepare more readable macro helpers.
>
> The other thing is can we please pretty please call it something other
> than "frob"?
Sure.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-13 15:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 20:41 [patch 0/2] Soft-dirty page tracker improvemens Cyrill Gorcunov
2013-07-30 20:41 ` [patch 1/2] [PATCH] mm: Save soft-dirty bits on swapped pages Cyrill Gorcunov
2013-07-31 8:16 ` Pavel Emelyanov
2013-08-01 0:51 ` Minchan Kim
2013-08-01 5:53 ` Cyrill Gorcunov
2013-08-01 6:16 ` Minchan Kim
2013-08-01 6:28 ` Cyrill Gorcunov
2013-08-01 6:37 ` Minchan Kim
2013-08-01 6:38 ` Cyrill Gorcunov
2013-08-05 1:48 ` Wanpeng Li
2013-08-05 1:48 ` Wanpeng Li
[not found] ` <51ff047d.2768310a.2fc4.340fSMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-05 2:17 ` Minchan Kim
2013-08-05 2:38 ` Wanpeng Li
2013-08-05 2:38 ` Wanpeng Li
[not found] ` <51ff1053.ab47310a.5d3f.566cSMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-05 2:54 ` Minchan Kim
2013-08-05 2:58 ` Wanpeng Li
2013-08-05 2:58 ` Wanpeng Li
[not found] ` <51ff14e9.87ef440a.1424.ffffe470SMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-05 5:43 ` Cyrill Gorcunov
2013-08-07 20:21 ` Andrew Morton
2013-08-07 20:29 ` Cyrill Gorcunov
2013-08-10 17:48 ` James Bottomley
2013-07-30 20:41 ` [patch 2/2] [PATCH] mm: Save soft-dirty bits on file pages Cyrill Gorcunov
2013-07-31 8:16 ` Pavel Emelyanov
2013-08-07 20:28 ` Andrew Morton
2013-08-07 20:31 ` Cyrill Gorcunov
2013-08-08 14:51 ` Cyrill Gorcunov
2013-08-12 21:57 ` Andrew Morton
2013-08-12 22:28 ` Andy Lutomirski
2013-08-12 22:37 ` Andrew Morton
2013-08-13 5:02 ` Cyrill Gorcunov
2013-08-13 15:14 ` H. Peter Anvin
2013-08-13 15:37 ` Cyrill Gorcunov [this message]
2013-08-13 16:43 ` H. Peter Anvin
2013-08-13 21:28 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813153703.GE2869@moon \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=mtosatti@redhat.com \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=xemul@parallels.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).