Re: [PATCH 7/7] drivers: base: refactor add_memory_section() to add_memory_block()

[Seth Jennings <sjenning@linux.vnet.ibm.com>]

On Thu, Aug 22, 2013 at 05:20:03PM +0900, Yasuaki Ishimatsu wrote:
> (2013/08/21 2:13), Seth Jennings wrote:
> > -	for (i = 0; i < NR_MEM_SECTIONS; i++) {
> > -		if (!present_section_nr(i))
> > -			continue;
> > -		/* don't need to reuse memory_block if only one per block */
> > -		err = add_memory_section(__nr_to_section(i),
> > -				 (sections_per_block == 1) ? NULL : &mem);
> > +	for (i = 0; i < NR_MEM_SECTIONS; i += sections_per_block) {
> 
> Why do you remove present_setcion_nr() check?

The previous logic was that if any section was present in the memory
block that the memory block is created.  If you do the
present_setcion_nr() check here, if the first section isn't
present, it skips the whole memory block, even though there may have
been other present sections in that block, which isn't what we want.

Seth

> 
> > +		err = add_memory_block(i);
> >   		if (!ret)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>