From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ning Qu <quning@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix accounting on page_remove_rmap()
Date: Tue, 3 Sep 2013 08:15:04 +0800 [thread overview]
Message-ID: <20130903001504.GA21530@hacker.(null)> (raw)
In-Reply-To: <1378122191-15479-1-git-send-email-kirill.shutemov@linux.intel.com>
On Mon, Sep 02, 2013 at 02:43:11PM +0300, Kirill A. Shutemov wrote:
>There's typo in page_remove_rmap(): we increase NR_ANON_PAGES counter
>instead of decreasing it. Let's fix this.
>
>Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>Reported-by: Ning Qu <quning@google.com>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>---
> mm/rmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/rmap.c b/mm/rmap.c
>index 52cc59a..6219f07 100644
>--- a/mm/rmap.c
>+++ b/mm/rmap.c
>@@ -1156,7 +1156,7 @@ void page_remove_rmap(struct page *page)
> __dec_zone_page_state(page,
> NR_ANON_TRANSPARENT_HUGEPAGES);
> __mod_zone_page_state(page_zone(page), NR_ANON_PAGES,
>- hpage_nr_pages(page));
>+ -hpage_nr_pages(page));
> } else {
> __dec_zone_page_state(page, NR_FILE_MAPPED);
> mem_cgroup_dec_page_stat(page, MEM_CGROUP_STAT_FILE_MAPPED);
>--
>1.8.4.rc3
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-03 0:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 11:43 [PATCH] mm: fix accounting on page_remove_rmap() Kirill A. Shutemov
2013-09-03 0:15 ` Wanpeng Li [this message]
2013-09-03 0:15 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130903001504.GA21530@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=quning@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).