From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx202.postini.com [74.125.245.202]) by kanga.kvack.org (Postfix) with SMTP id 555FF6B0032 for ; Mon, 2 Sep 2013 23:27:53 -0400 (EDT) Date: Mon, 2 Sep 2013 23:15:19 -0400 From: Chen Gong Subject: Re: [PATCH v2 2/4] mm/hwpoison: fix miss catch transparent huge page Message-ID: <20130903031519.GA31018@gchen.bj.intel.com> References: <1378165006-19435-1-git-send-email-liwanp@linux.vnet.ibm.com> <1378165006-19435-2-git-send-email-liwanp@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MGYHOYXEY6WxJCY8" Content-Disposition: inline In-Reply-To: <1378165006-19435-2-git-send-email-liwanp@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Wanpeng Li Cc: Andrew Morton , Andi Kleen , Fengguang Wu , Naoya Horiguchi , Tony Luck , linux-mm@kvack.org, linux-kernel@vger.kernel.org --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 03, 2013 at 07:36:44AM +0800, Wanpeng Li wrote: > Date: Tue, 3 Sep 2013 07:36:44 +0800 > From: Wanpeng Li > To: Andrew Morton > Cc: Andi Kleen , Fengguang Wu > , Naoya Horiguchi , > Tony Luck , gong.chen@linux.intel.com, > linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wanpeng Li > > Subject: [PATCH v2 2/4] mm/hwpoison: fix miss catch transparent huge page= =20 > X-Mailer: git-send-email 1.7.5.4 >=20 > Changelog: > *v1 -> v2: reverse PageTransHuge(page) && !PageHuge(page) check=20 >=20 > PageTransHuge() can't guarantee the page is transparent huge page since i= t=20 > return true for both transparent huge and hugetlbfs pages. This patch fix= =20 > it by check the page is also !hugetlbfs page. >=20 > Before patch: >=20 > [ 121.571128] Injecting memory failure at pfn 23a200 > [ 121.571141] MCE 0x23a200: huge page recovery: Delayed > [ 140.355100] MCE: Memory failure is now running on 0x23a200 >=20 > After patch: >=20 > [ 94.290793] Injecting memory failure at pfn 23a000 > [ 94.290800] MCE 0x23a000: huge page recovery: Delayed > [ 105.722303] MCE: Software-unpoisoned page 0x23a000 >=20 > Signed-off-by: Wanpeng Li > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index e28ee77..b114570 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1349,7 +1349,7 @@ int unpoison_memory(unsigned long pfn) > * worked by memory_failure() and the page lock is not held yet. > * In such case, we yield to memory_failure() and make unpoison fail. > */ > - if (PageTransHuge(page)) { > + if (!PageHuge(page) && PageTransHuge(page)) { > pr_info("MCE: Memory failure is now running on %#lx\n", pfn); > return 0; > } Not sure which git tree should be used to apply this patch series? I assume this patch series follows this link: https://lkml.org/lkml/2013/8/26/76. In unpoison_memory we already have if (PageHuge(page)) { ... return 0; } so it looks like this patch is redundant. --MGYHOYXEY6WxJCY8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJSJVRHAAoJEI01n1+kOSLH8moP/RFQ3ZOEI8aYMpMXkS/jamTw KX6z5PRBF/hX1k9DJJLCgpdrQ38YlMkf2+/D50KyZC83z8Cc3wpfSxJHelTR5m5M /szwq/VN2ZwIULV9dyEV/0g2n5mCCDnlgKCe6tJkslRlYrYXUq+q716mRflaNP+R 4VpVwjN2CxaO2ImHc1KrbXQq2/+XneyGL8ihRqEndkciuFo4d3b/2e/HnJADD+X6 OSyKKb31JoOq5IRqp1hI3zsj0ANLxt8FmJ/5hwxVOAXS+/gfWHdrBkmSj5q7cfX4 v04JeviNyWICsycVpLK5zHHZeiC48G1TSkv6R+w13/6dVcmmaD2CRBbf1JET4hdV zrYeWtHfkQ7w9U1uabi//w7Re0Q/kyEX78O6Obq8Pez8kBQMUw5Mo54ppdnfKdKF ld8g4Ay6TrsZy4MFWKDqwZLp+N5AveQUV9ch9g21vbN9GhtleZD5QOewT9yFqQD+ tzQyM3ed9x9ORJd6N0Q4YzTlFjUudxYPyRD4m9rkmo10B5jTDCweEvY/m0SXbgq4 GYpcW6Mzf83GAauJwsNnc95lamqFpQqYhOk1sCl4hLm+VCi2OcahAaau2KxT40O0 8HbKz2N7qY0ehVB0D3b6hkseQ2y2D/qq11zBOC301sd2RVK+P+we+8VPoD5Px40g bP9lGntS0KLJG6Zu9fTp =lHm5 -----END PGP SIGNATURE----- --MGYHOYXEY6WxJCY8-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org