From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] mm/vmalloc: move VM_UNINITIALIZED just before show_numa_info
Date: Tue, 3 Sep 2013 14:00:55 +0800 [thread overview]
Message-ID: <20130903060055.GA12697@hacker.(null)> (raw)
In-Reply-To: <5225765E.8000402@cn.fujitsu.com>
On Tue, Sep 03, 2013 at 01:40:46PM +0800, Zhang Yanfei wrote:
>On 09/03/2013 11:00 AM, Wanpeng Li wrote:
>> The VM_UNINITIALIZED/VM_UNLIST flag introduced by commit f5252e00(mm: avoid
>> null pointer access in vm_struct via /proc/vmallocinfo) is used to avoid
>> accessing the pages field with unallocated page when show_numa_info() is
>> called. This patch move the check just before show_numa_info in order that
>> some messages still can be dumped via /proc/vmallocinfo.
>>
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>
>Hmmm, sorry again. Please revert commit
>d157a55815ffff48caec311dfb543ce8a79e283e. That said, we could still
>do the check in show_numa_info like before.
>
Ok.
Regards,
Wanpeng Li
>> ---
>> mm/vmalloc.c | 10 +++++-----
>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
>> index e3ec8b4..c4720cd 100644
>> --- a/mm/vmalloc.c
>> +++ b/mm/vmalloc.c
>> @@ -2590,11 +2590,6 @@ static int s_show(struct seq_file *m, void *p)
>>
>> v = va->vm;
>>
>> - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */
>> - smp_rmb();
>> - if (v->flags & VM_UNINITIALIZED)
>> - return 0;
>> -
>> seq_printf(m, "0x%pK-0x%pK %7ld",
>> v->addr, v->addr + v->size, v->size);
>>
>> @@ -2622,6 +2617,11 @@ static int s_show(struct seq_file *m, void *p)
>> if (v->flags & VM_VPAGES)
>> seq_printf(m, " vpages");
>>
>> + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */
>> + smp_rmb();
>> + if (v->flags & VM_UNINITIALIZED)
>> + return 0;
>> +
>> show_numa_info(m, v);
>> seq_putc(m, '\n');
>> return 0;
>>
>
>
>--
>Thanks.
>Zhang Yanfei
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-03 6:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 3:00 [PATCH v2 1/3] mm/vmalloc: don't set area->caller twice Wanpeng Li
2013-09-03 3:00 ` [PATCH v2 2/3] mm/vmalloc: don't warning vmalloc allocation failure twice Wanpeng Li
2013-09-03 5:38 ` Zhang Yanfei
2013-09-03 3:00 ` [PATCH v2 3/3] mm/vmalloc: move VM_UNINITIALIZED just before show_numa_info Wanpeng Li
2013-09-03 5:40 ` Zhang Yanfei
2013-09-03 6:00 ` Wanpeng Li [this message]
2013-09-03 6:00 ` Wanpeng Li
2013-09-03 5:34 ` [PATCH v2 1/3] mm/vmalloc: don't set area->caller twice Zhang Yanfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130903060055.GA12697@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).