From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Chen Gong <gong.chen@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Tony Luck <tony.luck@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] mm/hwpoison: fix miss catch transparent huge page
Date: Tue, 3 Sep 2013 15:59:02 +0800 [thread overview]
Message-ID: <20130903075902.GA4995@hacker.(null)> (raw)
In-Reply-To: <20130903041858.GA3543@hacker.(null)>
Hi Chen,
On Tue, Sep 03, 2013 at 12:18:58PM +0800, Wanpeng Li wrote:
>On Mon, Sep 02, 2013 at 11:15:19PM -0400, Chen Gong wrote:
>>On Tue, Sep 03, 2013 at 07:36:44AM +0800, Wanpeng Li wrote:
>>> Date: Tue, 3 Sep 2013 07:36:44 +0800
>>> From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>>> To: Andrew Morton <akpm@linux-foundation.org>
>>> Cc: Andi Kleen <andi@firstfloor.org>, Fengguang Wu
>>> <fengguang.wu@intel.com>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
>>> Tony Luck <tony.luck@intel.com>, gong.chen@linux.intel.com,
>>> linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wanpeng Li
>>> <liwanp@linux.vnet.ibm.com>
>>> Subject: [PATCH v2 2/4] mm/hwpoison: fix miss catch transparent huge page
>>> X-Mailer: git-send-email 1.7.5.4
>>>
>>> Changelog:
>>> *v1 -> v2: reverse PageTransHuge(page) && !PageHuge(page) check
>>>
>>> PageTransHuge() can't guarantee the page is transparent huge page since it
>>> return true for both transparent huge and hugetlbfs pages. This patch fix
>>> it by check the page is also !hugetlbfs page.
>>>
>>> Before patch:
>>>
>>> [ 121.571128] Injecting memory failure at pfn 23a200
>>> [ 121.571141] MCE 0x23a200: huge page recovery: Delayed
>>> [ 140.355100] MCE: Memory failure is now running on 0x23a200
>>>
>>> After patch:
>>>
>>> [ 94.290793] Injecting memory failure at pfn 23a000
>>> [ 94.290800] MCE 0x23a000: huge page recovery: Delayed
>>> [ 105.722303] MCE: Software-unpoisoned page 0x23a000
>>>
>>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>>> ---
>>> mm/memory-failure.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
>>> index e28ee77..b114570 100644
>>> --- a/mm/memory-failure.c
>>> +++ b/mm/memory-failure.c
>>> @@ -1349,7 +1349,7 @@ int unpoison_memory(unsigned long pfn)
>>> * worked by memory_failure() and the page lock is not held yet.
>>> * In such case, we yield to memory_failure() and make unpoison fail.
>>> */
>>> - if (PageTransHuge(page)) {
>>> + if (!PageHuge(page) && PageTransHuge(page)) {
>>> pr_info("MCE: Memory failure is now running on %#lx\n", pfn);
>>> return 0;
>>> }
>>
>>Not sure which git tree should be used to apply this patch series? I assume
>>this patch series follows this link: https://lkml.org/lkml/2013/8/26/76.
>>
>
>mmotm tree or linux-next. ;-)
>
>>In unpoison_memory we already have
>> if (PageHuge(page)) {
>> ...
>> return 0;
>> }
>>so it looks like this patch is redundant.
>
>- Do you aware there is condition before go to this check?
>- Do you also analysis why the check can't catch the hugetlbfs page
> through the dump information?
>
If I miss something, don't mind to point out. ;-)
Regards,
Wanpeng Li
>Regards,
>Wanpeng Li
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-03 7:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 23:36 [PATCH v2 1/4] mm/hwpoison: fix traverse hugetlbfs page to avoid printk flood Wanpeng Li
2013-09-02 23:36 ` [PATCH v2 2/4] mm/hwpoison: fix miss catch transparent huge page Wanpeng Li
2013-09-03 0:20 ` Naoya Horiguchi
2013-09-03 3:15 ` Chen Gong
2013-09-03 4:18 ` Wanpeng Li
2013-09-03 4:18 ` Wanpeng Li
2013-09-03 7:59 ` Wanpeng Li [this message]
2013-09-03 7:59 ` Wanpeng Li
[not found] ` <52256342.4ad52a0a.2e24.ffff8c60SMTPIN_ADDED_BROKEN@mx.google.com>
2013-09-03 8:04 ` Chen Gong
2013-09-03 8:21 ` Wanpeng Li
2013-09-03 8:21 ` Wanpeng Li
2013-09-02 23:36 ` [PATCH v2 3/4] mm/hwpoison: fix false report 2nd try page recovery Wanpeng Li
2013-09-02 23:36 ` [PATCH v2 4/4] mm/hwpoison: fix the lack of one reference count against poisoned page Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130903075902.GA4995@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).